This is an automated email from the ASF dual-hosted git repository.
zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new cba5d1e9ba5 Remove useless SQLStatement.getDatabaseType() (#35540)
cba5d1e9ba5 is described below
commit cba5d1e9ba587019ebdd67171beb64429e16aa4d
Author: Liang Zhang <[email protected]>
AuthorDate: Wed May 28 00:38:46 2025 +0800
Remove useless SQLStatement.getDatabaseType() (#35540)
* Remove useless SQLStatement.getDatabaseType()
* Remove useless SQLStatement.getDatabaseType()
---
.../sql/parser/statement/core/statement/SQLStatement.java | 11 -----------
.../sql/parser/statement/clickhouse/ClickHouseStatement.java | 7 -------
.../sql/parser/statement/doris/DorisStatement.java | 7 -------
.../sql/parser/statement/firebird/FirebirdStatement.java | 7 -------
.../sql/parser/statement/hive/HiveStatement.java | 7 -------
.../sql/parser/statement/mysql/MySQLStatement.java | 7 -------
.../sql/parser/statement/opengauss/OpenGaussStatement.java | 7 -------
.../sql/parser/statement/oracle/OracleStatement.java | 7 -------
.../sql/parser/statement/postgresql/PostgreSQLStatement.java | 7 -------
.../sql/parser/statement/presto/PrestoStatement.java | 7 -------
.../sql/parser/statement/sqlserver/SQLServerStatement.java | 7 -------
11 files changed, 81 deletions(-)
diff --git
a/parser/sql/statement/core/src/main/java/org/apache/shardingsphere/sql/parser/statement/core/statement/SQLStatement.java
b/parser/sql/statement/core/src/main/java/org/apache/shardingsphere/sql/parser/statement/core/statement/SQLStatement.java
index 0173773fee0..91cae15ba70 100644
---
a/parser/sql/statement/core/src/main/java/org/apache/shardingsphere/sql/parser/statement/core/statement/SQLStatement.java
+++
b/parser/sql/statement/core/src/main/java/org/apache/shardingsphere/sql/parser/statement/core/statement/SQLStatement.java
@@ -17,8 +17,6 @@
package org.apache.shardingsphere.sql.parser.statement.core.statement;
-import org.apache.shardingsphere.infra.database.core.type.DatabaseType;
-import org.apache.shardingsphere.infra.spi.type.typed.TypedSPILoader;
import org.apache.shardingsphere.sql.parser.api.ASTNode;
import java.util.Collection;
@@ -36,15 +34,6 @@ public interface SQLStatement extends ASTNode {
*/
int getParameterCount();
- /**
- * Get database type.
- *
- * @return database type
- */
- default DatabaseType getDatabaseType() {
- return TypedSPILoader.getService(DatabaseType.class, "SQL92");
- }
-
/**
* Get variable names.
*
diff --git
a/parser/sql/statement/type/clickhouse/src/main/java/org/apache/shardingsphere/sql/parser/statement/clickhouse/ClickHouseStatement.java
b/parser/sql/statement/type/clickhouse/src/main/java/org/apache/shardingsphere/sql/parser/statement/clickhouse/ClickHouseStatement.java
index 62e451065a9..38bbceb642f 100644
---
a/parser/sql/statement/type/clickhouse/src/main/java/org/apache/shardingsphere/sql/parser/statement/clickhouse/ClickHouseStatement.java
+++
b/parser/sql/statement/type/clickhouse/src/main/java/org/apache/shardingsphere/sql/parser/statement/clickhouse/ClickHouseStatement.java
@@ -17,17 +17,10 @@
package org.apache.shardingsphere.sql.parser.statement.clickhouse;
-import org.apache.shardingsphere.infra.database.core.type.DatabaseType;
-import org.apache.shardingsphere.infra.spi.type.typed.TypedSPILoader;
import
org.apache.shardingsphere.sql.parser.statement.core.statement.SQLStatement;
/**
* ClickHouse statement.
*/
public interface ClickHouseStatement extends SQLStatement {
-
- @Override
- default DatabaseType getDatabaseType() {
- return TypedSPILoader.getService(DatabaseType.class, "ClickHouse");
- }
}
diff --git
a/parser/sql/statement/type/doris/src/main/java/org/apache/shardingsphere/sql/parser/statement/doris/DorisStatement.java
b/parser/sql/statement/type/doris/src/main/java/org/apache/shardingsphere/sql/parser/statement/doris/DorisStatement.java
index 729d863ba09..96e361e5cd5 100644
---
a/parser/sql/statement/type/doris/src/main/java/org/apache/shardingsphere/sql/parser/statement/doris/DorisStatement.java
+++
b/parser/sql/statement/type/doris/src/main/java/org/apache/shardingsphere/sql/parser/statement/doris/DorisStatement.java
@@ -17,17 +17,10 @@
package org.apache.shardingsphere.sql.parser.statement.doris;
-import org.apache.shardingsphere.infra.database.core.type.DatabaseType;
-import org.apache.shardingsphere.infra.spi.type.typed.TypedSPILoader;
import
org.apache.shardingsphere.sql.parser.statement.core.statement.SQLStatement;
/**
* Doris statement.
*/
public interface DorisStatement extends SQLStatement {
-
- @Override
- default DatabaseType getDatabaseType() {
- return TypedSPILoader.getService(DatabaseType.class, "Doris");
- }
}
diff --git
a/parser/sql/statement/type/firebird/src/main/java/org/apache/shardingsphere/sql/parser/statement/firebird/FirebirdStatement.java
b/parser/sql/statement/type/firebird/src/main/java/org/apache/shardingsphere/sql/parser/statement/firebird/FirebirdStatement.java
index fb194f0c957..ea13347ec92 100644
---
a/parser/sql/statement/type/firebird/src/main/java/org/apache/shardingsphere/sql/parser/statement/firebird/FirebirdStatement.java
+++
b/parser/sql/statement/type/firebird/src/main/java/org/apache/shardingsphere/sql/parser/statement/firebird/FirebirdStatement.java
@@ -17,17 +17,10 @@
package org.apache.shardingsphere.sql.parser.statement.firebird;
-import org.apache.shardingsphere.infra.database.core.type.DatabaseType;
-import org.apache.shardingsphere.infra.spi.type.typed.TypedSPILoader;
import
org.apache.shardingsphere.sql.parser.statement.core.statement.SQLStatement;
/**
* Firebird statement.
*/
public interface FirebirdStatement extends SQLStatement {
-
- @Override
- default DatabaseType getDatabaseType() {
- return TypedSPILoader.getService(DatabaseType.class, "Firebird");
- }
}
diff --git
a/parser/sql/statement/type/hive/src/main/java/org/apache/shardingsphere/sql/parser/statement/hive/HiveStatement.java
b/parser/sql/statement/type/hive/src/main/java/org/apache/shardingsphere/sql/parser/statement/hive/HiveStatement.java
index 74cf421e69b..a96313b5386 100644
---
a/parser/sql/statement/type/hive/src/main/java/org/apache/shardingsphere/sql/parser/statement/hive/HiveStatement.java
+++
b/parser/sql/statement/type/hive/src/main/java/org/apache/shardingsphere/sql/parser/statement/hive/HiveStatement.java
@@ -17,17 +17,10 @@
package org.apache.shardingsphere.sql.parser.statement.hive;
-import org.apache.shardingsphere.infra.database.core.type.DatabaseType;
-import org.apache.shardingsphere.infra.spi.type.typed.TypedSPILoader;
import
org.apache.shardingsphere.sql.parser.statement.core.statement.SQLStatement;
/**
* Hive statement.
*/
public interface HiveStatement extends SQLStatement {
-
- @Override
- default DatabaseType getDatabaseType() {
- return TypedSPILoader.getService(DatabaseType.class, "Hive");
- }
}
diff --git
a/parser/sql/statement/type/mysql/src/main/java/org/apache/shardingsphere/sql/parser/statement/mysql/MySQLStatement.java
b/parser/sql/statement/type/mysql/src/main/java/org/apache/shardingsphere/sql/parser/statement/mysql/MySQLStatement.java
index d019467ecb7..15ddfb444d4 100644
---
a/parser/sql/statement/type/mysql/src/main/java/org/apache/shardingsphere/sql/parser/statement/mysql/MySQLStatement.java
+++
b/parser/sql/statement/type/mysql/src/main/java/org/apache/shardingsphere/sql/parser/statement/mysql/MySQLStatement.java
@@ -17,17 +17,10 @@
package org.apache.shardingsphere.sql.parser.statement.mysql;
-import org.apache.shardingsphere.infra.database.core.type.DatabaseType;
-import org.apache.shardingsphere.infra.spi.type.typed.TypedSPILoader;
import
org.apache.shardingsphere.sql.parser.statement.core.statement.SQLStatement;
/**
* MySQL statement.
*/
public interface MySQLStatement extends SQLStatement {
-
- @Override
- default DatabaseType getDatabaseType() {
- return TypedSPILoader.getService(DatabaseType.class, "MySQL");
- }
}
diff --git
a/parser/sql/statement/type/opengauss/src/main/java/org/apache/shardingsphere/sql/parser/statement/opengauss/OpenGaussStatement.java
b/parser/sql/statement/type/opengauss/src/main/java/org/apache/shardingsphere/sql/parser/statement/opengauss/OpenGaussStatement.java
index 14d46a64af8..fe153b71e91 100644
---
a/parser/sql/statement/type/opengauss/src/main/java/org/apache/shardingsphere/sql/parser/statement/opengauss/OpenGaussStatement.java
+++
b/parser/sql/statement/type/opengauss/src/main/java/org/apache/shardingsphere/sql/parser/statement/opengauss/OpenGaussStatement.java
@@ -17,17 +17,10 @@
package org.apache.shardingsphere.sql.parser.statement.opengauss;
-import org.apache.shardingsphere.infra.database.core.type.DatabaseType;
-import org.apache.shardingsphere.infra.spi.type.typed.TypedSPILoader;
import
org.apache.shardingsphere.sql.parser.statement.core.statement.SQLStatement;
/**
* OpenGauss statement.
*/
public interface OpenGaussStatement extends SQLStatement {
-
- @Override
- default DatabaseType getDatabaseType() {
- return TypedSPILoader.getService(DatabaseType.class, "openGauss");
- }
}
diff --git
a/parser/sql/statement/type/oracle/src/main/java/org/apache/shardingsphere/sql/parser/statement/oracle/OracleStatement.java
b/parser/sql/statement/type/oracle/src/main/java/org/apache/shardingsphere/sql/parser/statement/oracle/OracleStatement.java
index 84f7fc55d98..cc9414b8ef1 100644
---
a/parser/sql/statement/type/oracle/src/main/java/org/apache/shardingsphere/sql/parser/statement/oracle/OracleStatement.java
+++
b/parser/sql/statement/type/oracle/src/main/java/org/apache/shardingsphere/sql/parser/statement/oracle/OracleStatement.java
@@ -17,17 +17,10 @@
package org.apache.shardingsphere.sql.parser.statement.oracle;
-import org.apache.shardingsphere.infra.database.core.type.DatabaseType;
-import org.apache.shardingsphere.infra.spi.type.typed.TypedSPILoader;
import
org.apache.shardingsphere.sql.parser.statement.core.statement.SQLStatement;
/**
* Oracle statement.
*/
public interface OracleStatement extends SQLStatement {
-
- @Override
- default DatabaseType getDatabaseType() {
- return TypedSPILoader.getService(DatabaseType.class, "Oracle");
- }
}
diff --git
a/parser/sql/statement/type/postgresql/src/main/java/org/apache/shardingsphere/sql/parser/statement/postgresql/PostgreSQLStatement.java
b/parser/sql/statement/type/postgresql/src/main/java/org/apache/shardingsphere/sql/parser/statement/postgresql/PostgreSQLStatement.java
index 8c5934ba696..f0585f37d0d 100644
---
a/parser/sql/statement/type/postgresql/src/main/java/org/apache/shardingsphere/sql/parser/statement/postgresql/PostgreSQLStatement.java
+++
b/parser/sql/statement/type/postgresql/src/main/java/org/apache/shardingsphere/sql/parser/statement/postgresql/PostgreSQLStatement.java
@@ -17,17 +17,10 @@
package org.apache.shardingsphere.sql.parser.statement.postgresql;
-import org.apache.shardingsphere.infra.database.core.type.DatabaseType;
-import org.apache.shardingsphere.infra.spi.type.typed.TypedSPILoader;
import
org.apache.shardingsphere.sql.parser.statement.core.statement.SQLStatement;
/**
* PostgreSQL statement.
*/
public interface PostgreSQLStatement extends SQLStatement {
-
- @Override
- default DatabaseType getDatabaseType() {
- return TypedSPILoader.getService(DatabaseType.class, "PostgreSQL");
- }
}
diff --git
a/parser/sql/statement/type/presto/src/main/java/org/apache/shardingsphere/sql/parser/statement/presto/PrestoStatement.java
b/parser/sql/statement/type/presto/src/main/java/org/apache/shardingsphere/sql/parser/statement/presto/PrestoStatement.java
index 99fd0dc6e08..2a001036127 100644
---
a/parser/sql/statement/type/presto/src/main/java/org/apache/shardingsphere/sql/parser/statement/presto/PrestoStatement.java
+++
b/parser/sql/statement/type/presto/src/main/java/org/apache/shardingsphere/sql/parser/statement/presto/PrestoStatement.java
@@ -17,17 +17,10 @@
package org.apache.shardingsphere.sql.parser.statement.presto;
-import org.apache.shardingsphere.infra.database.core.type.DatabaseType;
-import org.apache.shardingsphere.infra.spi.type.typed.TypedSPILoader;
import
org.apache.shardingsphere.sql.parser.statement.core.statement.SQLStatement;
/**
* Presto statement.
*/
public interface PrestoStatement extends SQLStatement {
-
- @Override
- default DatabaseType getDatabaseType() {
- return TypedSPILoader.getService(DatabaseType.class, "Presto");
- }
}
diff --git
a/parser/sql/statement/type/sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/statement/sqlserver/SQLServerStatement.java
b/parser/sql/statement/type/sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/statement/sqlserver/SQLServerStatement.java
index b83503894fb..6894f8787b5 100644
---
a/parser/sql/statement/type/sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/statement/sqlserver/SQLServerStatement.java
+++
b/parser/sql/statement/type/sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/statement/sqlserver/SQLServerStatement.java
@@ -17,17 +17,10 @@
package org.apache.shardingsphere.sql.parser.statement.sqlserver;
-import org.apache.shardingsphere.infra.database.core.type.DatabaseType;
-import org.apache.shardingsphere.infra.spi.type.typed.TypedSPILoader;
import
org.apache.shardingsphere.sql.parser.statement.core.statement.SQLStatement;
/**
* SQLServer statement.
*/
public interface SQLServerStatement extends SQLStatement {
-
- @Override
- default DatabaseType getDatabaseType() {
- return TypedSPILoader.getService(DatabaseType.class, "SQLServer");
- }
}
