This is an automated email from the ASF dual-hosted git repository.
zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new fb59b7bfdcb Refactor SQLBindEngine (#35656)
fb59b7bfdcb is described below
commit fb59b7bfdcbdfd31e4b8ea081416c799c2b40a6b
Author: Liang Zhang <[email protected]>
AuthorDate: Tue Jun 10 00:52:53 2025 +0800
Refactor SQLBindEngine (#35656)
---
.../shardingsphere/infra/binder/engine/SQLBindEngine.java | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git
a/infra/binder/core/src/main/java/org/apache/shardingsphere/infra/binder/engine/SQLBindEngine.java
b/infra/binder/core/src/main/java/org/apache/shardingsphere/infra/binder/engine/SQLBindEngine.java
index ca14a10a5f7..19fd29ced39 100644
---
a/infra/binder/core/src/main/java/org/apache/shardingsphere/infra/binder/engine/SQLBindEngine.java
+++
b/infra/binder/core/src/main/java/org/apache/shardingsphere/infra/binder/engine/SQLBindEngine.java
@@ -57,15 +57,11 @@ public final class SQLBindEngine {
* @return SQL statement context
*/
public SQLStatementContext bind(final DatabaseType databaseType, final
SQLStatement sqlStatement, final List<Object> params) {
- SQLStatement boundSQLStatement = isNeedBind() ?
bindSQLStatement(databaseType, sqlStatement) : sqlStatement;
+ SQLStatement boundSQLStatement = isNeedBind() ? bind(databaseType,
sqlStatement) : sqlStatement;
return SQLStatementContextFactory.newInstance(metaData, databaseType,
boundSQLStatement, params, currentDatabaseName);
}
- private boolean isNeedBind() {
- return !hintValueContext.findHintDataSourceName().isPresent() &&
!HintManager.getDataSourceName().isPresent();
- }
-
- private SQLStatement bindSQLStatement(final DatabaseType databaseType,
final SQLStatement statement) {
+ private SQLStatement bind(final DatabaseType databaseType, final
SQLStatement statement) {
if (statement instanceof DMLStatement) {
return new DMLStatementBindEngine(metaData, currentDatabaseName,
hintValueContext, databaseType).bind((DMLStatement) statement);
}
@@ -80,4 +76,8 @@ public final class SQLBindEngine {
}
return statement;
}
+
+ private boolean isNeedBind() {
+ return !hintValueContext.findHintDataSourceName().isPresent() &&
!HintManager.getDataSourceName().isPresent();
+ }
}