This is an automated email from the ASF dual-hosted git repository.
zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new 1099e7e986c Refactor MigrateTableStatement.sourceTargetEntries (#36103)
1099e7e986c is described below
commit 1099e7e986c6b510bf699f0377ff86d6ecbf812e
Author: Liang Zhang <[email protected]>
AuthorDate: Tue Jul 29 14:53:44 2025 +0800
Refactor MigrateTableStatement.sourceTargetEntries (#36103)
---
.../statement/updatable/MigrateTableStatement.java | 4 ++--
.../migration/update/MigrateTableStatementAssert.java | 15 ++++++++-------
2 files changed, 10 insertions(+), 9 deletions(-)
diff --git
a/kernel/data-pipeline/scenario/migration/distsql/statement/src/main/java/org/apache/shardingsphere/data/pipeline/scenario/migration/distsql/statement/updatable/MigrateTableStatement.java
b/kernel/data-pipeline/scenario/migration/distsql/statement/src/main/java/org/apache/shardingsphere/data/pipeline/scenario/migration/distsql/statement/updatable/MigrateTableStatement.java
index fb325c648ba..11f22fb7ebd 100644
---
a/kernel/data-pipeline/scenario/migration/distsql/statement/src/main/java/org/apache/shardingsphere/data/pipeline/scenario/migration/distsql/statement/updatable/MigrateTableStatement.java
+++
b/kernel/data-pipeline/scenario/migration/distsql/statement/src/main/java/org/apache/shardingsphere/data/pipeline/scenario/migration/distsql/statement/updatable/MigrateTableStatement.java
@@ -22,7 +22,7 @@ import lombok.RequiredArgsConstructor;
import
org.apache.shardingsphere.data.pipeline.distsql.statement.updatable.UpdatablePipelineRALStatement;
import
org.apache.shardingsphere.data.pipeline.scenario.migration.distsql.segment.MigrationSourceTargetSegment;
-import java.util.List;
+import java.util.Collection;
/**
* Migrate table statement.
@@ -31,7 +31,7 @@ import java.util.List;
@Getter
public final class MigrateTableStatement extends UpdatablePipelineRALStatement
{
- private final List<MigrationSourceTargetSegment> sourceTargetEntries;
+ private final Collection<MigrationSourceTargetSegment> sourceTargetEntries;
private final String targetDatabaseName;
}
diff --git
a/test/it/parser/src/main/java/org/apache/shardingsphere/test/it/sql/parser/internal/asserts/statement/ral/type/pipeline/migration/update/MigrateTableStatementAssert.java
b/test/it/parser/src/main/java/org/apache/shardingsphere/test/it/sql/parser/internal/asserts/statement/ral/type/pipeline/migration/update/MigrateTableStatementAssert.java
index 6835aea7cfc..30ab0295f95 100644
---
a/test/it/parser/src/main/java/org/apache/shardingsphere/test/it/sql/parser/internal/asserts/statement/ral/type/pipeline/migration/update/MigrateTableStatementAssert.java
+++
b/test/it/parser/src/main/java/org/apache/shardingsphere/test/it/sql/parser/internal/asserts/statement/ral/type/pipeline/migration/update/MigrateTableStatementAssert.java
@@ -44,12 +44,13 @@ public final class MigrateTableStatementAssert {
public static void assertIs(final SQLCaseAssertContext assertContext,
final MigrateTableStatement actual, final MigrateTableStatementTestCase
expected) {
assertThat(assertContext.getText("target database name does not
match"), actual.getTargetDatabaseName(), is(expected.getTargetDatabaseName()));
assertThat(actual.getSourceTargetEntries().size(), is(1));
- MigrationSourceTargetSegment segment =
actual.getSourceTargetEntries().get(0);
- DataNode dataNode = new DataNode(segment.getSourceDatabaseName(),
segment.getSourceTableName());
- dataNode.setSchemaName(segment.getSourceSchemaName());
- assertThat(assertContext.getText("source database name does not
match"), dataNode.getDataSourceName(), is(expected.getSourceResourceName()));
- assertThat(assertContext.getText("source schema name does not match"),
dataNode.getSchemaName(), is(expected.getSourceSchemaName()));
- assertThat(assertContext.getText("source table name does not match"),
dataNode.getTableName(), is(expected.getSourceTableName()));
- assertThat(assertContext.getText("target table name does not match"),
segment.getTargetTableName(), is(expected.getTargetTableName()));
+ for (MigrationSourceTargetSegment each :
actual.getSourceTargetEntries()) {
+ DataNode dataNode = new DataNode(each.getSourceDatabaseName(),
each.getSourceTableName());
+ dataNode.setSchemaName(each.getSourceSchemaName());
+ assertThat(assertContext.getText("source database name does not
match"), dataNode.getDataSourceName(), is(expected.getSourceResourceName()));
+ assertThat(assertContext.getText("source schema name does not
match"), dataNode.getSchemaName(), is(expected.getSourceSchemaName()));
+ assertThat(assertContext.getText("source table name does not
match"), dataNode.getTableName(), is(expected.getSourceTableName()));
+ assertThat(assertContext.getText("target table name does not
match"), each.getTargetTableName(), is(expected.getTargetTableName()));
+ }
}
}