ClaireLytt commented on code in PR #36492:
URL: https://github.com/apache/shardingsphere/pull/36492#discussion_r2328640386
##########
test/e2e/sql/src/test/java/org/apache/shardingsphere/test/e2e/sql/env/DataSetEnvironmentManager.java:
##########
@@ -94,10 +94,19 @@ public void fillData() {
}
String insertSQL;
try (Connection connection =
dataSourceMap.get(dataNode.getDataSourceName()).getConnection()) {
- DatabaseType databaseType =
DatabaseTypeFactory.get(connection.getMetaData().getURL());
- insertSQL = generateInsertSQL(dataNode.getTableName(),
dataSetMetaData.getColumns(), databaseType);
+ DatabaseType currentDatabaseType;
+ try {
+ currentDatabaseType =
DatabaseTypeFactory.get(connection.getMetaData().getURL());
+ } catch (final SQLException ex) {
+ currentDatabaseType = databaseType;
+ }
+ String insertTableName = dataNode.getTableName();
Review Comment:
I have removed the local variable currentDatabaseType and the try-catch
exception handling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
