linghengqian commented on code in PR #2475:
URL:
https://github.com/apache/shardingsphere-elasticjob/pull/2475#discussion_r2329274749
##########
test/native/src/test/java/org/apache/shardingsphere/elasticjob/test/natived/it/operation/JavaTest.java:
##########
@@ -305,4 +308,47 @@ void testShardingStatisticsAPI() {
});
job.shutdown();
}
+
+ @Test
+ void
testGivenOneShardingCountWhenShutdownThenTaskCanCaptureInterruptedException()
throws Exception {
+ testCaptureInterruptedException(1);
+ }
+
+ @Test
+ void
testGivenOneMoreShardingCountWhenShutdownThenTaskCanCaptureInterruptedException()
throws Exception {
+ testCaptureInterruptedException(2);
+ }
+
+ private void testCaptureInterruptedException(int shardingTotalCount)
throws Exception {
+ String jobName = "testTaskCaptureInterruptedTask";
+ final AtomicBoolean captured = new AtomicBoolean(false);
+ // start in 2 seconds
+ LocalTime tenSecondsLater = LocalTime.now().plusSeconds(2);
+ String cronExpression = String.format("%d %d %d * * ?",
tenSecondsLater.getSecond(), tenSecondsLater.getMinute(),
tenSecondsLater.getHour());
+ SimpleJob captureInterruptedTask = shardingContext -> {
+ int i = 0;
+ try {
+ while (true) {
+ if (Thread.currentThread().isInterrupted()) {
+ captured.set(true);
+ break;
+ }
+ i++;
+ Thread.sleep(100);
+ }
+ } catch (InterruptedException e) {
+ captured.set(true);
+ Thread.currentThread().interrupt();
+ }
+ };
+ ScheduleJobBootstrap job = new ScheduleJobBootstrap(firstRegCenter,
captureInterruptedTask,
+ JobConfiguration.newBuilder(jobName, shardingTotalCount)
+ .cron(cronExpression)
+ .build());
+ job.schedule();
+ Thread.sleep(4_000);
Review Comment:
I'll say I'm confused as to why `Thread#sleep` is necessary. What happens if
we use `Awaitility.await().pollDelay(4L, TimeUnit.SECONDS).until(() -> true);`?
https://github.com/apache/shardingsphere/issues/24106 is introducing stricter
code constraints to avoid `Thread#sleep`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
