This is an automated email from the ASF dual-hosted git repository.

zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 679f7fc87db Refactor ShardingSphereMultiProxiesClusterContainer 
(#36633)
679f7fc87db is described below

commit 679f7fc87db2acd43cbc52d85028afa8a1de9a5a
Author: Liang Zhang <[email protected]>
AuthorDate: Fri Sep 19 19:17:10 2025 +0800

    Refactor ShardingSphereMultiProxiesClusterContainer (#36633)
---
 .../ShardingSphereMultiProxiesClusterContainer.java  | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git 
a/test/e2e/env/src/test/java/org/apache/shardingsphere/test/e2e/env/container/adapter/impl/ShardingSphereMultiProxiesClusterContainer.java
 
b/test/e2e/env/src/test/java/org/apache/shardingsphere/test/e2e/env/container/adapter/impl/ShardingSphereMultiProxiesClusterContainer.java
index d0551e0ea2d..d120be90710 100644
--- 
a/test/e2e/env/src/test/java/org/apache/shardingsphere/test/e2e/env/container/adapter/impl/ShardingSphereMultiProxiesClusterContainer.java
+++ 
b/test/e2e/env/src/test/java/org/apache/shardingsphere/test/e2e/env/container/adapter/impl/ShardingSphereMultiProxiesClusterContainer.java
@@ -30,8 +30,8 @@ import java.io.PrintWriter;
 import java.sql.Connection;
 import java.sql.SQLException;
 import java.sql.SQLFeatureNotSupportedException;
+import java.util.Arrays;
 import java.util.Collection;
-import java.util.LinkedList;
 import java.util.Set;
 import java.util.concurrent.ThreadLocalRandom;
 import java.util.concurrent.atomic.AtomicReference;
@@ -45,17 +45,17 @@ public final class 
ShardingSphereMultiProxiesClusterContainer implements Adapter
     
     private final AtomicReference<DataSource> targetDataSourceProvider = new 
AtomicReference<>();
     
-    private final Collection<ShardingSphereProxyClusterContainer> 
proxyClusterContainers = new LinkedList<>();
+    private final Collection<ShardingSphereProxyClusterContainer> 
proxyClusterContainers;
     
     public ShardingSphereMultiProxiesClusterContainer(final DatabaseType 
databaseType, final AdaptorContainerConfiguration config) {
-        ShardingSphereProxyClusterContainer proxy1 = new 
ShardingSphereProxyClusterContainer(databaseType, config);
-        proxy1.setAbbreviation("proxy1");
-        proxy1.setName("proxy1");
-        proxyClusterContainers.add(proxy1);
-        ShardingSphereProxyClusterContainer proxy2 = new 
ShardingSphereProxyClusterContainer(databaseType, config);
-        proxy1.setAbbreviation("proxy2");
-        proxy1.setName("proxy2");
-        proxyClusterContainers.add(proxy2);
+        proxyClusterContainers = 
Arrays.asList(createProxyClusterContainer(databaseType, config, "proxy1"), 
createProxyClusterContainer(databaseType, config, "proxy2"));
+    }
+    
+    private ShardingSphereProxyClusterContainer 
createProxyClusterContainer(final DatabaseType databaseType, final 
AdaptorContainerConfiguration config, final String name) {
+        ShardingSphereProxyClusterContainer result = new 
ShardingSphereProxyClusterContainer(databaseType, config);
+        result.setAbbreviation(name);
+        result.setName(name);
+        return result;
     }
     
     @Override

Reply via email to