This is an automated email from the ASF dual-hosted git repository.

zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 8d4b5c44943 Refactor TransactionBaseE2EIT (#36718)
8d4b5c44943 is described below

commit 8d4b5c44943b87a7514ffe168ba7f050dfe65862
Author: Liang Zhang <[email protected]>
AuthorDate: Fri Sep 26 11:46:59 2025 +0800

    Refactor TransactionBaseE2EIT (#36718)
---
 .../transaction/engine/base/TransactionBaseE2EIT.java      | 14 +-------------
 1 file changed, 1 insertion(+), 13 deletions(-)

diff --git 
a/test/e2e/operation/transaction/src/test/java/org/apache/shardingsphere/test/e2e/operation/transaction/engine/base/TransactionBaseE2EIT.java
 
b/test/e2e/operation/transaction/src/test/java/org/apache/shardingsphere/test/e2e/operation/transaction/engine/base/TransactionBaseE2EIT.java
index 13e7c43cb5b..181288d0dba 100644
--- 
a/test/e2e/operation/transaction/src/test/java/org/apache/shardingsphere/test/e2e/operation/transaction/engine/base/TransactionBaseE2EIT.java
+++ 
b/test/e2e/operation/transaction/src/test/java/org/apache/shardingsphere/test/e2e/operation/transaction/engine/base/TransactionBaseE2EIT.java
@@ -423,24 +423,12 @@ public abstract class TransactionBaseE2EIT {
                                        final List<TransactionType> 
transactionTypes, final List<String> providers, final String scenario, final 
Class<? extends BaseTransactionTestCase> caseClass) {
             String key = getUniqueKey(registry.getDatabaseType(), 
registry.getRunningAdaptor(), transactionTypes, providers, scenario);
             testParams.putIfAbsent(key, new 
TransactionTestParameter(registry.getDatabaseType(),
-                    registry.getRunningAdaptor(), 
ENV.getArtifactEnvironment().getProxyPortBindings(), transactionTypes, 
providers,
-                    getStorageContainerImageName(registry.getDatabaseType(), 
databaseVersion), scenario, new LinkedList<>()));
+                    registry.getRunningAdaptor(), 
ENV.getArtifactEnvironment().getProxyPortBindings(), transactionTypes, 
providers, databaseVersion, scenario, new LinkedList<>()));
             testParams.get(key).getTransactionTestCaseClasses().add(caseClass);
         }
         
         private String getUniqueKey(final DatabaseType databaseType, final 
String runningAdapter, final List<TransactionType> transactionTypes, final 
List<String> providers, final String scenario) {
             return String.join(File.separator, databaseType.getType(), 
runningAdapter, transactionTypes.toString(), providers.toString(), scenario);
         }
-        
-        private String getStorageContainerImageName(final DatabaseType 
databaseType, final String databaseVersion) {
-            switch (databaseType.getType()) {
-                case TransactionTestConstants.MYSQL:
-                case TransactionTestConstants.POSTGRESQL:
-                case TransactionTestConstants.OPENGAUSS:
-                    return databaseVersion;
-                default:
-                    throw new 
UnsupportedOperationException(String.format("Unsupported database type `%s`.", 
databaseType));
-            }
-        }
     }
 }

Reply via email to