This is an automated email from the ASF dual-hosted git repository.
menghaoran pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new 1e08aff1400 Views will not be persisted when federation not enabled
(#36762)
1e08aff1400 is described below
commit 1e08aff1400ce4af52b02942a72bcb33cc0b0f08
Author: Haoran Meng <[email protected]>
AuthorDate: Thu Oct 9 11:13:22 2025 +0800
Views will not be persisted when federation not enabled (#36762)
* Views will not be persisted when federation not enabled
* Refactor DALE2EIT
* Fix checkstyle for DALE2EIT
---
.../pushdown/type/view/AlterViewPushDownMetaDataRefresher.java | 7 -------
.../pushdown/type/view/CreateViewPushDownMetaDataRefresher.java | 2 --
.../apache/shardingsphere/test/e2e/sql/it/sql/dal/DALE2EIT.java | 3 +++
3 files changed, 3 insertions(+), 9 deletions(-)
diff --git
a/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/pushdown/type/view/AlterViewPushDownMetaDataRefresher.java
b/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/pushdown/type/view/AlterViewPushDownMetaDataRefresher.java
index e01c2ed32df..85af47e0575 100644
---
a/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/pushdown/type/view/AlterViewPushDownMetaDataRefresher.java
+++
b/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/pushdown/type/view/AlterViewPushDownMetaDataRefresher.java
@@ -50,29 +50,22 @@ public final class AlterViewPushDownMetaDataRefresher
implements PushDownMetaDat
final String schemaName, final DatabaseType
databaseType, final AlterViewStatement sqlStatement, final
ConfigurationProperties props) throws SQLException {
String viewName =
TableRefreshUtils.getTableName(sqlStatement.getView().getTableName().getIdentifier(),
databaseType);
Collection<ShardingSphereTable> alteredTables = new LinkedList<>();
- Collection<ShardingSphereView> alteredViews = new LinkedList<>();
Collection<String> droppedTables = new LinkedList<>();
- Collection<String> droppedViews = new LinkedList<>();
Optional<SimpleTableSegment> renameView = sqlStatement.getRenameView();
if (renameView.isPresent()) {
String renameViewName =
renameView.get().getTableName().getIdentifier().getValue();
String originalView =
database.getSchema(schemaName).getView(viewName).getViewDefinition();
ShardingSphereSchema schema = getSchema(database,
logicDataSourceName, schemaName, renameViewName, originalView, props);
alteredTables.add(schema.getTable(renameViewName));
- alteredViews.add(schema.getView(renameViewName));
droppedTables.add(viewName);
- droppedViews.add(viewName);
}
Optional<String> viewDefinition = sqlStatement.getViewDefinition();
if (viewDefinition.isPresent()) {
ShardingSphereSchema schema = getSchema(database,
logicDataSourceName, schemaName, viewName, viewDefinition.get(), props);
alteredTables.add(schema.getTable(viewName));
- alteredViews.add(schema.getView(viewName));
}
metaDataManagerPersistService.alterTables(database, schemaName,
alteredTables);
- metaDataManagerPersistService.alterViews(database, schemaName,
alteredViews);
metaDataManagerPersistService.dropTables(database, schemaName,
droppedTables);
- metaDataManagerPersistService.dropViews(database, schemaName,
droppedViews);
}
private ShardingSphereSchema getSchema(final ShardingSphereDatabase
database, final String logicDataSourceName,
diff --git
a/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/pushdown/type/view/CreateViewPushDownMetaDataRefresher.java
b/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/pushdown/type/view/CreateViewPushDownMetaDataRefresher.java
index 7536567add5..b2075a24273 100644
---
a/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/pushdown/type/view/CreateViewPushDownMetaDataRefresher.java
+++
b/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/pushdown/type/view/CreateViewPushDownMetaDataRefresher.java
@@ -26,7 +26,6 @@ import
org.apache.shardingsphere.infra.metadata.database.schema.builder.GenericS
import
org.apache.shardingsphere.infra.metadata.database.schema.builder.GenericSchemaBuilderMaterial;
import
org.apache.shardingsphere.infra.metadata.database.schema.model.ShardingSphereSchema;
import
org.apache.shardingsphere.infra.metadata.database.schema.model.ShardingSphereTable;
-import
org.apache.shardingsphere.infra.metadata.database.schema.model.ShardingSphereView;
import
org.apache.shardingsphere.infra.rule.attribute.datanode.MutableDataNodeRuleAttribute;
import
org.apache.shardingsphere.mode.metadata.refresher.pushdown.PushDownMetaDataRefresher;
import
org.apache.shardingsphere.mode.metadata.refresher.util.TableRefreshUtils;
@@ -57,7 +56,6 @@ public final class CreateViewPushDownMetaDataRefresher
implements PushDownMetaDa
Optional<ShardingSphereTable> actualTableMetaData =
Optional.ofNullable(schemas.get(schemaName)).map(optional ->
optional.getTable(viewName));
Preconditions.checkState(actualTableMetaData.isPresent(), "Load actual
view metadata '%s' failed.", viewName);
metaDataManagerPersistService.alterTables(database, schemaName,
Collections.singleton(actualTableMetaData.get()));
- metaDataManagerPersistService.alterViews(database, schemaName,
Collections.singleton(new ShardingSphereView(viewName,
sqlStatement.getViewDefinition())));
}
@Override
diff --git
a/test/e2e/sql/src/test/java/org/apache/shardingsphere/test/e2e/sql/it/sql/dal/DALE2EIT.java
b/test/e2e/sql/src/test/java/org/apache/shardingsphere/test/e2e/sql/it/sql/dal/DALE2EIT.java
index 7340eebae73..425d346ecdf 100644
---
a/test/e2e/sql/src/test/java/org/apache/shardingsphere/test/e2e/sql/it/sql/dal/DALE2EIT.java
+++
b/test/e2e/sql/src/test/java/org/apache/shardingsphere/test/e2e/sql/it/sql/dal/DALE2EIT.java
@@ -70,7 +70,10 @@ class DALE2EIT implements SQLE2EIT {
try (Connection connection =
environmentEngine.getTargetDataSource().getConnection()) {
try (Statement statement = connection.createStatement()) {
statement.execute(context.getSQL());
+ Thread.sleep(1000L);
assertExecuteResult(context, statement);
+ } catch (final InterruptedException ignore) {
+ Thread.currentThread().interrupt();
}
}
}
