terrymanu commented on issue #37022:
URL:
https://github.com/apache/shardingsphere/issues/37022#issuecomment-3496348702
Problem Analysis
Your concern is absolutely valid. After thorough analysis, I confirm that
the ShardingSphere-SQL naming does not align with common practices in the Java
ecosystem.
Root Cause
The current naming ShardingSphere-SQL has the following issues:
1. Does not conform to package name conventions used by most Java projects
2. Requires special handling from users when configuring logs, preventing
unified package-based configuration
Fix Suggestion
Recommend modifying the naming in SQLLogger.java as follows:
```java
// Current code
@Slf4j(topic = "ShardingSphere-SQL")
public final class SQLLogger {
```
```java
// Suggested change to
@Slf4j(topic = "org.apache.shardingsphere.sql")
public final class SQLLogger {
```
Impact Scope
This change would affect the following files:
1.
infra/executor/src/main/java/org/apache/shardingsphere/infra/executor/sql/log/SQLLogger.java
2. Related test configuration files
3. Configuration examples in official documentation
Invitation to Participate
Thank you very much for raising this valuable improvement suggestion! This
would indeed make ShardingSphere more aligned with standard practices in the
Java ecosystem.
We warmly invite you to submit a Pull Request to implement this
improvement:
1. Modify the topic name in SQLLogger.java
2. Update related test configurations
3. Synchronize configuration examples in official documentation
4. Add corresponding test cases to verify the changes
Your participation can help make ShardingSphere better, and we look
forward to your contribution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
