(shardingsphere) branch master updated: Refactor FirebirdStartTransactionPacket (#37599)

[zhangliang]

This is an automated email from the ASF dual-hosted git repository.

zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 1395a578908 Refactor FirebirdStartTransactionPacket (#37599)
1395a578908 is described below

commit 1395a578908625d51392f57b9302601933f72563
Author: Liang Zhang <zhangli...@apache.org>
AuthorDate: Thu Jan 1 12:53:12 2026 +0800

    Refactor FirebirdStartTransactionPacket (#37599)
    
    * Refactor FirebirdStartTransactionPacket
    
    * Refactor FirebirdStartTransactionPacket
---
 .../query/transaction/FirebirdStartTransactionPacket.java | 15 ++++++++++++---
 .../FirebirdStartTransactionCommandExecutor.java          |  4 ++--
 .../FirebirdStartTransactionCommandExecutorTest.java      |  4 ++--
 3 files changed, 16 insertions(+), 7 deletions(-)

diff --git 
a/database/protocol/dialect/firebird/src/main/java/org/apache/shardingsphere/database/protocol/firebird/packet/command/query/transaction/FirebirdStartTransactionPacket.java
 
b/database/protocol/dialect/firebird/src/main/java/org/apache/shardingsphere/database/protocol/firebird/packet/command/query/transaction/FirebirdStartTransactionPacket.java
index 303f0493e72..3404a4d4397 100644
--- 
a/database/protocol/dialect/firebird/src/main/java/org/apache/shardingsphere/database/protocol/firebird/packet/command/query/transaction/FirebirdStartTransactionPacket.java
+++ 
b/database/protocol/dialect/firebird/src/main/java/org/apache/shardingsphere/database/protocol/firebird/packet/command/query/transaction/FirebirdStartTransactionPacket.java
@@ -40,11 +40,21 @@ public final class FirebirdStartTransactionPacket extends 
FirebirdCommandPacket
         tpb.parseBuffer(payload.readBuffer());
     }
     
-    public boolean getAutocommit() {
+    /**
+     * Is auto commit.
+     *
+     * @return auto commit or not
+     */
+    public boolean isAutocommit() {
         return null != 
tpb.getValue(FirebirdTransactionParameterBufferType.AUTOCOMMIT);
     }
     
-    public boolean getReadOnly() {
+    /**
+     * Is read only.
+     *
+     * @return read only or not
+     */
+    public boolean isReadOnly() {
         return null != 
tpb.getValue(FirebirdTransactionParameterBufferType.READ);
     }
     
@@ -68,7 +78,6 @@ public final class FirebirdStartTransactionPacket extends 
FirebirdCommandPacket
     
     @Override
     protected void write(final FirebirdPacketPayload payload) {
-        
     }
     
     /**
diff --git 
a/proxy/frontend/dialect/firebird/src/main/java/org/apache/shardingsphere/proxy/frontend/firebird/command/query/transaction/FirebirdStartTransactionCommandExecutor.java
 
b/proxy/frontend/dialect/firebird/src/main/java/org/apache/shardingsphere/proxy/frontend/firebird/command/query/transaction/FirebirdStartTransactionCommandExecutor.java
index 676050d8960..4e556d13473 100644
--- 
a/proxy/frontend/dialect/firebird/src/main/java/org/apache/shardingsphere/proxy/frontend/firebird/command/query/transaction/FirebirdStartTransactionCommandExecutor.java
+++ 
b/proxy/frontend/dialect/firebird/src/main/java/org/apache/shardingsphere/proxy/frontend/firebird/command/query/transaction/FirebirdStartTransactionCommandExecutor.java
@@ -39,8 +39,8 @@ public final class FirebirdStartTransactionCommandExecutor 
implements CommandExe
     
     @Override
     public Collection<DatabasePacket> execute() {
-        connectionSession.setAutoCommit(packet.getAutocommit());
-        connectionSession.setReadOnly(packet.getReadOnly());
+        connectionSession.setAutoCommit(packet.isAutocommit());
+        connectionSession.setReadOnly(packet.isReadOnly());
         connectionSession.setIsolationLevel(packet.getIsolationLevel());
         int transactionId = 
FirebirdTransactionIdGenerator.getInstance().nextTransactionId(connectionSession.getConnectionId());
         return Collections.singleton(new 
FirebirdGenericResponsePacket().setHandle(transactionId));
diff --git 
a/proxy/frontend/dialect/firebird/src/test/java/org/apache/shardingsphere/proxy/frontend/firebird/command/query/transaction/FirebirdStartTransactionCommandExecutorTest.java
 
b/proxy/frontend/dialect/firebird/src/test/java/org/apache/shardingsphere/proxy/frontend/firebird/command/query/transaction/FirebirdStartTransactionCommandExecutorTest.java
index 8bf8e4efcab..6d57c80b0bb 100644
--- 
a/proxy/frontend/dialect/firebird/src/test/java/org/apache/shardingsphere/proxy/frontend/firebird/command/query/transaction/FirebirdStartTransactionCommandExecutorTest.java
+++ 
b/proxy/frontend/dialect/firebird/src/test/java/org/apache/shardingsphere/proxy/frontend/firebird/command/query/transaction/FirebirdStartTransactionCommandExecutorTest.java
@@ -62,8 +62,8 @@ class FirebirdStartTransactionCommandExecutorTest {
     
     @Test
     void assertExecute() {
-        when(packet.getAutocommit()).thenReturn(true);
-        when(packet.getReadOnly()).thenReturn(true);
+        when(packet.isAutocommit()).thenReturn(true);
+        when(packet.isReadOnly()).thenReturn(true);
         
when(packet.getIsolationLevel()).thenReturn(TransactionIsolationLevel.SERIALIZABLE);
         FirebirdStartTransactionCommandExecutor executor = new 
FirebirdStartTransactionCommandExecutor(packet, connectionSession);
         Collection<DatabasePacket> actual = executor.execute();