Copilot commented on code in PR #37640:
URL: https://github.com/apache/shardingsphere/pull/37640#discussion_r2659789881
##########
test/it/parser/src/main/resources/sql/supported/dml/presto.xml:
##########
@@ -88,4 +88,7 @@
<sql-case id="presto_select_udf_with_param" value="SELECT my_udf(order_id)
FROM t_order" db-types="Presto" />
<sql-case id="presto_insert_select_no_columns" value="INSERT INTO t_order
SELECT 1" db-types="Presto" />
<sql-case id="presto_insert_values_empty_columns" value="INSERT INTO
t_order () VALUES (1)" db-types="Presto" />
+ <sql-case id="presto_select_cast_lengths" value="SELECT CAST(order_id AS
DECIMAL(10,2)) FROM t_order" db-types="Presto" />
+ <sql-case id="presto_select_window_partition_only" value="SELECT
ROW_NUMBER() OVER win FROM t_order WINDOW win AS (PARTITION BY status)"
db-types="Presto" />
+ <sql-case id="presto_delete_order_limit" value="DELETE FROM t_order WHERE
flag = 1 ORDER BY order_id LIMIT 1" db-types="Presto" />
Review Comment:
The PR title mentions "Add more test cases on Doris SQL parser" but these
test cases are for Presto, not Doris. The db-types attribute correctly
specifies "Presto", but the PR title should be updated to accurately reflect
that these are Presto test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
