linghengqian opened a new issue, #37642:
URL: https://github.com/apache/shardingsphere/issues/37642

   ## Feature Request
   
   **For English only**, other languages will not be accepted.
   
   Please pay attention on issues you submitted, because we maybe need more 
details. 
   If no response anymore and we cannot make decision by current information, 
we will **close it**.
   
   Please answer these questions before submitting your issue. Thanks!
   
   ### Is your feature request related to a problem?
   
   - See https://github.com/actions/runner-images/issues/13474 .
   
   ### Describe the feature you would like.
   
   - I personally believe it's necessary to support native tests running the 
master branch on either Docker Engine v28 or Docker Engine v29. Currently, in 
the GitHub Actions CI files, the Ubuntu Runner uses Docker Engine v27, and the 
Windows Server Runner uses Rancher Desktop, which bundles Docker Engine v28.
   - Because the master branch is using 
`org.testcontainers:testcontainers-bom:2.0.1`, executing `./mvnw 
-PgenerateMetadata -e -T 1C clean verify` via Docker Engine v29 will not find 
the Docker environment, which is affected by 
https://github.com/testcontainers/testcontainers-java/issues/11212 . On the 
other hand, the updated version `org.testcontainers:testcontainers-bom:2.0.3` 
only supports Docker Engine v29 and later, which conflicts with the default 
configuration of Rancher Desktop. See 
https://github.com/testcontainers/testcontainers-java/issues/11254 .
   - If we don't wait for https://github.com/actions/runner-images/issues/13474 
to close, we need to do something similar for all CIs involving testcontainers.
   - Therefore, the current direction for resolving this issue seems to be as 
follows:
   - [ ] The documentation should be updated to require developers using Docker 
Engine v29 to perform the following actions:
   ```bash
   sudo tee /etc/docker/daemon.json <<EOF
   {
     "log-driver": "local",
     "min-api-version": "1.24"
   }
   EOF
   
   sudo systemctl restart docker.service
   ```
   
   - [ ] After https://github.com/actions/runner-images/issues/13474 is closed, 
bump the testcontainers version to `2.0.3`.
   - [ ] After https://github.com/actions/runner-images/issues/13474 is closed, 
update the documentation to require developers on Windows 11 to update the 
`/etc/docker/daemon.json` configuration for Rancher Desktop to use 
`min-api-version`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: 
[email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to