ccxxxyy commented on PR #38074: URL: https://github.com/apache/shardingsphere/pull/38074#issuecomment-3919344690
@terrymanu Hi, thank you very much for your feedback and guidance! I have made the requested changes and would greatly appreciate it if you could review them when you have time. Below is a summary of the updates in this commit: 1. I refined the unsetVariable rule in `DALStatement.java` to support the syntax format without parentheses. 2. I added corresponding test cases and assertions for the syntax without parentheses in: src/main/resources/sql/supported/dal/unset.xml src/main/resources/case/dal/unset.xml All assertion tests pass successfully. The assertions involving the default <effective_scope> (i.e., when the scope is not explicitly specified) are: `<unset-variable sql-case-id="unset_variable_default_scope" scope="SESSION" variable-name="exec_mem_limit" />` `<unset-variable sql-case-id="unset_variable_default_scope_without_parentheses" scope="SESSION" variable-name="time_zone" />` Both assertion tests pass, and the parsing behavior has been verified. 3. I modified the `UnsetVariableStatement` implementation as requested, adjusting the construction logic of the statement properties. I hope these changes meet the requirements. Thank you again for your time and support! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
