This is an automated email from the ASF dual-hosted git repository.
zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new 14acf573ba8 Add more test cases on FirebirdBlobInfoRegistryTest
(#38116)
14acf573ba8 is described below
commit 14acf573ba847b17a945d57e41725e09273b62ad
Author: Liang Zhang <[email protected]>
AuthorDate: Sat Feb 21 18:26:56 2026 +0800
Add more test cases on FirebirdBlobInfoRegistryTest (#38116)
* Add more test cases on FirebirdBlobInfoRegistryTest
* Add more test cases on FirebirdBlobInfoRegistryTest
---
.../data/FirebirdBlobInfoRegistryTest.java | 125 ++++++++++++++++++---
1 file changed, 110 insertions(+), 15 deletions(-)
diff --git
a/database/connector/dialect/firebird/src/test/java/org/apache/shardingsphere/database/connector/firebird/metadata/data/FirebirdBlobInfoRegistryTest.java
b/database/connector/dialect/firebird/src/test/java/org/apache/shardingsphere/database/connector/firebird/metadata/data/FirebirdBlobInfoRegistryTest.java
index bf714c6027c..a3dc37faf47 100644
---
a/database/connector/dialect/firebird/src/test/java/org/apache/shardingsphere/database/connector/firebird/metadata/data/FirebirdBlobInfoRegistryTest.java
+++
b/database/connector/dialect/firebird/src/test/java/org/apache/shardingsphere/database/connector/firebird/metadata/data/FirebirdBlobInfoRegistryTest.java
@@ -17,39 +17,134 @@
package org.apache.shardingsphere.database.connector.firebird.metadata.data;
+import org.mockito.internal.configuration.plugins.Plugins;
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.Arguments;
+import org.junit.jupiter.params.provider.MethodSource;
import java.util.Collections;
+import java.util.HashMap;
+import java.util.Map;
import java.util.OptionalInt;
+import java.util.stream.Stream;
import static org.hamcrest.Matchers.is;
import static org.hamcrest.MatcherAssert.assertThat;
import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertThrows;
import static org.junit.jupiter.api.Assertions.assertTrue;
class FirebirdBlobInfoRegistryTest {
+ private Map<String, Map<String, Integer>> blobColumns;
+
+ @BeforeEach
+ @SuppressWarnings("unchecked")
+ void setUp() throws ReflectiveOperationException {
+ blobColumns = (Map<String, Map<String, Integer>>)
Plugins.getMemberAccessor().get(FirebirdBlobInfoRegistry.class.getDeclaredField("BLOB_COLUMNS"),
FirebirdBlobInfoRegistry.class);
+ blobColumns.clear();
+ }
+
+ @AfterEach
+ void tearDown() {
+ blobColumns.clear();
+ }
+
+ @ParameterizedTest(name = "{0}")
+ @MethodSource("refreshTableRemoveCases")
+ void assertRefreshTableRemovesEntry(final String name, final Map<String,
Integer> newColumns) {
+ blobColumns.put("SCHEMA_A.TABLE_A",
Collections.singletonMap("EXISTING_COL", 1));
+ FirebirdBlobInfoRegistry.refreshTable("schema_a", "table_a",
newColumns);
+ assertFalse(blobColumns.containsKey("SCHEMA_A.TABLE_A"));
+ }
+
@Test
- void assertRefreshAndFindBlobSubtype() {
- FirebirdBlobInfoRegistry.refreshTable("schema_a", "table_a",
Collections.singletonMap("blob_col", 2));
- OptionalInt actual =
FirebirdBlobInfoRegistry.findBlobSubtype("schema_a", "table_a", "BLOB_COL");
- assertTrue(actual.isPresent());
- assertThat(actual.getAsInt(), is(2));
- assertTrue(FirebirdBlobInfoRegistry.isBlobColumn("schema_a",
"table_a", "blob_col"));
- FirebirdBlobInfoRegistry.refreshTable("schema_a", "table_a",
Collections.emptyMap());
+ void assertRefreshTableWhenTableNameIsNull() {
+ registerBlobColumns("SENTINEL",
Collections.singletonMap("EXISTING_COL", 9));
+ FirebirdBlobInfoRegistry.refreshTable("schema_a", null,
Collections.singletonMap("blob_col", 1));
+ assertTrue(blobColumns.containsKey("SENTINEL"));
+ assertThat(blobColumns.get("SENTINEL").get("EXISTING_COL"), is(9));
+ }
+
+ @Test
+ void assertRefreshTable() {
+ Map<String, Integer> newColumns = createColumnsWithMixedNames();
+ FirebirdBlobInfoRegistry.refreshTable(null, "table_1", newColumns);
+ Map<String, Integer> actual = blobColumns.get(".TABLE");
+ assertTrue(actual.containsKey("BLOB_COL"));
+ assertThat(actual.get("BLOB_COL"), is(2));
+ assertThat(actual.size(), is(1));
+ assertThrows(UnsupportedOperationException.class, () ->
actual.put("ANOTHER_COL", 3));
+ }
+
+ @ParameterizedTest(name = "{0}")
+ @MethodSource("notBlobColumnCases")
+ void assertIsBlobColumnWhenNotMatched(final String name, final String
tableName, final String columnName, final boolean registerTable, final boolean
registerColumn) {
+ if (registerTable) {
+ blobColumns.put("SCHEMA_A.TABLE_A", registerColumn ?
Collections.singletonMap("BLOB_COL", 1) : Collections.singletonMap("OTHER_COL",
1));
+ }
+ assertFalse(FirebirdBlobInfoRegistry.isBlobColumn("schema_a",
tableName, columnName));
}
@Test
- void assertRefreshTableRemovesEntryWhenEmpty() {
- FirebirdBlobInfoRegistry.refreshTable("schema_b", "table_b",
Collections.singletonMap("blob_col", 1));
- FirebirdBlobInfoRegistry.refreshTable("schema_b", "table_b",
Collections.emptyMap());
- assertFalse(FirebirdBlobInfoRegistry.isBlobColumn("schema_b",
"table_b", "blob_col"));
+ void assertIsBlobColumn() {
+ registerBlobColumns("SCHEMA_A.123",
Collections.singletonMap("BLOB_COL", 1));
+ boolean actual = FirebirdBlobInfoRegistry.isBlobColumn("schema_a",
"123", "blob_col");
+ assertTrue(actual);
+ }
+
+ @ParameterizedTest(name = "{0}")
+ @MethodSource("findBlobSubtypeEmptyCases")
+ void assertFindBlobSubtypeWhenAbsent(final String name, final String
tableName, final String columnName, final boolean registerTable, final boolean
registerColumn) {
+ if (registerTable) {
+ blobColumns.put("SCHEMA_A.TABLE_A", registerColumn ?
Collections.singletonMap("BLOB_COL", 5) : Collections.singletonMap("OTHER_COL",
5));
+ }
+ OptionalInt actual =
FirebirdBlobInfoRegistry.findBlobSubtype("schema_a", tableName, columnName);
+ assertFalse(actual.isPresent());
}
@Test
- void assertTrimLogicTableNameMatches() {
- FirebirdBlobInfoRegistry.refreshTable("schema_c", "table_1",
Collections.singletonMap("blob_col", 3));
- assertTrue(FirebirdBlobInfoRegistry.isBlobColumn("schema_c",
"table_2", "blob_col"));
- FirebirdBlobInfoRegistry.refreshTable("schema_c", "table_1",
Collections.emptyMap());
+ void assertFindBlobSubtype() {
+ registerBlobColumns("SCHEMA_A.TABLE_A",
Collections.singletonMap("BLOB_COL", 7));
+ OptionalInt actual =
FirebirdBlobInfoRegistry.findBlobSubtype("schema_a", "table_a", "blob_col");
+ assertTrue(actual.isPresent());
+ assertThat(actual.getAsInt(), is(7));
+ }
+
+ private static Stream<Arguments> refreshTableRemoveCases() {
+ return Stream.of(
+ Arguments.of("null_blob_columns", null),
+ Arguments.of("empty_blob_columns", Collections.emptyMap()),
+ Arguments.of("all_column_names_are_null",
Collections.singletonMap(null, 1)));
+ }
+
+ private static Stream<Arguments> notBlobColumnCases() {
+ return Stream.of(
+ Arguments.of("null_table_name", null, "blob_col", false,
false),
+ Arguments.of("null_column_name", "table_a", null, true, true),
+ Arguments.of("table_not_registered", "table_a", "blob_col",
false, false),
+ Arguments.of("column_not_registered", "table_a", "blob_col",
true, false));
+ }
+
+ private static Stream<Arguments> findBlobSubtypeEmptyCases() {
+ return Stream.of(
+ Arguments.of("null_table_name", null, "blob_col", false,
false),
+ Arguments.of("null_column_name", "table_a", null, true, true),
+ Arguments.of("table_not_registered", "table_a", "blob_col",
false, false),
+ Arguments.of("column_not_registered", "table_a", "blob_col",
true, false));
+ }
+
+ private static Map<String, Integer> createColumnsWithMixedNames() {
+ Map<String, Integer> result = new HashMap<>(2, 1F);
+ result.put("blob_col", 2);
+ result.put(null, 9);
+ return result;
+ }
+
+ private void registerBlobColumns(final String tableKey, final Map<String,
Integer> columns) {
+ blobColumns.put(tableKey, columns);
}
}
