aviralgarg05 opened a new pull request, #38186:
URL: https://github.com/apache/shardingsphere/pull/38186
Fixes #36212.
Changes proposed in this pull request:
- Fixed `SET NAMES` handling in MySQL and Doris parser visitors so it now
maps to all relevant session variables: `character_set_client`,
`character_set_results`, and `character_set_connection`.
- Updated MySQL proxy charset variable handling to honor
`character_set_results` and `character_set_connection` (in addition to existing
charset variables), so response charset behavior is no longer tied only to
`character_set_client`.
- Added and updated focused tests to cover the new behavior in parser and
proxy modules.
- Updated parser integration test expectations for `SET NAMES` / `SET
CHARSET` cases to match MySQL semantics.
---
Before committing this PR, I'm sure that I have checked the following
options:
- [x] My code follows the [code of
conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/)
of this project.
- [x] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the
pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C
-Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [x] I have added corresponding unit tests for my changes.
- [ ] I have updated the Release Notes of the current development version.
For more details, see [Update Release
Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
