This is an automated email from the ASF dual-hosted git repository.
zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new a072897b410 Code format for
AlterReadwriteSplittingStorageUnitStatusExecutorTest (#38264)
a072897b410 is described below
commit a072897b4109a556e15cd3f287e506b917540390
Author: Liang Zhang <[email protected]>
AuthorDate: Sat Feb 28 12:34:45 2026 +0800
Code format for AlterReadwriteSplittingStorageUnitStatusExecutorTest
(#38264)
---
.../AlterReadwriteSplittingStorageUnitStatusExecutorTest.java | 3 ++-
.../handler/update/CreateReadwriteSplittingRuleExecutorTest.java | 6 ++----
.../handler/update/DropReadwriteSplittingRuleExecutorTest.java | 9 +++------
3 files changed, 7 insertions(+), 11 deletions(-)
diff --git
a/features/readwrite-splitting/distsql/handler/src/test/java/org/apache/shardingsphere/readwritesplitting/distsql/handler/update/AlterReadwriteSplittingStorageUnitStatusExecutorTest.java
b/features/readwrite-splitting/distsql/handler/src/test/java/org/apache/shardingsphere/readwritesplitting/distsql/handler/update/AlterReadwriteSplittingStorageUnitStatusExecutorTest.java
index 7d5c41276bc..8232d4ebf04 100644
---
a/features/readwrite-splitting/distsql/handler/src/test/java/org/apache/shardingsphere/readwritesplitting/distsql/handler/update/AlterReadwriteSplittingStorageUnitStatusExecutorTest.java
+++
b/features/readwrite-splitting/distsql/handler/src/test/java/org/apache/shardingsphere/readwritesplitting/distsql/handler/update/AlterReadwriteSplittingStorageUnitStatusExecutorTest.java
@@ -117,7 +117,8 @@ class AlterReadwriteSplittingStorageUnitStatusExecutorTest {
private static Stream<Arguments> executeUpdateFailureArguments() {
return Stream.of(
- Arguments.of("missing readwrite-splitting rule", null,
Collections.singleton("read_ds_0"), Collections.emptySet(), true,
MissingRequiredRuleException.class),
+ Arguments.of("missing readwrite-splitting rule", null,
Collections.singleton("read_ds_0"), Collections.emptySet(), true,
+ MissingRequiredRuleException.class),
Arguments.of("missing read storage unit", "readwrite_group",
Collections.singleton("read_ds_1"), Collections.emptySet(), true,
ReadwriteSplittingActualDataSourceNotFoundException.class),
Arguments.of("enable storage unit that is not disabled",
"readwrite_group", Collections.singleton("read_ds_0"), Collections.emptySet(),
true,
diff --git
a/features/readwrite-splitting/distsql/handler/src/test/java/org/apache/shardingsphere/readwritesplitting/distsql/handler/update/CreateReadwriteSplittingRuleExecutorTest.java
b/features/readwrite-splitting/distsql/handler/src/test/java/org/apache/shardingsphere/readwritesplitting/distsql/handler/update/CreateReadwriteSplittingRuleExecutorTest.java
index 1b9ab2435f1..9b5be3b8a03 100644
---
a/features/readwrite-splitting/distsql/handler/src/test/java/org/apache/shardingsphere/readwritesplitting/distsql/handler/update/CreateReadwriteSplittingRuleExecutorTest.java
+++
b/features/readwrite-splitting/distsql/handler/src/test/java/org/apache/shardingsphere/readwritesplitting/distsql/handler/update/CreateReadwriteSplittingRuleExecutorTest.java
@@ -132,10 +132,8 @@ class CreateReadwriteSplittingRuleExecutorTest {
private static Stream<Arguments>
buildToBeCreatedRuleConfigurationArguments() {
return Stream.of(
Arguments.of("if not exists with null rule", null, new
LinkedList<>(Collections.singleton(createRuleSegment("readwrite_ds_1"))), 1),
- Arguments.of("if not exists removes duplicated rule",
createCurrentRuleConfiguration(),
- new
LinkedList<>(Collections.singleton(createRuleSegment("readwrite_ds_0"))), 0),
- Arguments.of("if not exists keeps non duplicated rule",
createCurrentRuleConfiguration(),
- new
LinkedList<>(Collections.singleton(createRuleSegment("readwrite_ds_1"))), 1));
+ Arguments.of("if not exists removes duplicated rule",
createCurrentRuleConfiguration(), new
LinkedList<>(Collections.singleton(createRuleSegment("readwrite_ds_0"))), 0),
+ Arguments.of("if not exists keeps non duplicated rule",
createCurrentRuleConfiguration(), new
LinkedList<>(Collections.singleton(createRuleSegment("readwrite_ds_1"))), 1));
}
private static ReadwriteSplittingRuleSegment createRuleSegment(final
String ruleName) {
diff --git
a/features/readwrite-splitting/distsql/handler/src/test/java/org/apache/shardingsphere/readwritesplitting/distsql/handler/update/DropReadwriteSplittingRuleExecutorTest.java
b/features/readwrite-splitting/distsql/handler/src/test/java/org/apache/shardingsphere/readwritesplitting/distsql/handler/update/DropReadwriteSplittingRuleExecutorTest.java
index 1b87e307730..f0c1ce64c4b 100644
---
a/features/readwrite-splitting/distsql/handler/src/test/java/org/apache/shardingsphere/readwritesplitting/distsql/handler/update/DropReadwriteSplittingRuleExecutorTest.java
+++
b/features/readwrite-splitting/distsql/handler/src/test/java/org/apache/shardingsphere/readwritesplitting/distsql/handler/update/DropReadwriteSplittingRuleExecutorTest.java
@@ -178,17 +178,14 @@ class DropReadwriteSplittingRuleExecutorTest {
}
private static ReadwriteSplittingRuleConfiguration
createCurrentRuleConfigurationWithoutLoadBalancerName() {
- ReadwriteSplittingDataSourceGroupRuleConfiguration
dataSourceGroupConfig = new
ReadwriteSplittingDataSourceGroupRuleConfiguration("readwrite_ds",
- "", new LinkedList<>(), null);
+ ReadwriteSplittingDataSourceGroupRuleConfiguration
dataSourceGroupConfig = new
ReadwriteSplittingDataSourceGroupRuleConfiguration("readwrite_ds", "", new
LinkedList<>(), null);
Map<String, AlgorithmConfiguration> loadBalancers =
Collections.singletonMap("readwrite_ds", new AlgorithmConfiguration("TEST", new
Properties()));
return new ReadwriteSplittingRuleConfiguration(new
LinkedList<>(Collections.singleton(dataSourceGroupConfig)), loadBalancers);
}
private static ReadwriteSplittingRuleConfiguration
createMultipleCurrentRuleConfigurations() {
- ReadwriteSplittingDataSourceGroupRuleConfiguration
fooDataSourceGroupConfig = new
ReadwriteSplittingDataSourceGroupRuleConfiguration(
- "foo_ds", "", new LinkedList<>(), "TEST");
- ReadwriteSplittingDataSourceGroupRuleConfiguration
barDataSourceGroupConfig = new
ReadwriteSplittingDataSourceGroupRuleConfiguration(
- "bar_ds", "", new LinkedList<>(), "TEST");
+ ReadwriteSplittingDataSourceGroupRuleConfiguration
fooDataSourceGroupConfig = new
ReadwriteSplittingDataSourceGroupRuleConfiguration("foo_ds", "", new
LinkedList<>(), "TEST");
+ ReadwriteSplittingDataSourceGroupRuleConfiguration
barDataSourceGroupConfig = new
ReadwriteSplittingDataSourceGroupRuleConfiguration("bar_ds", "", new
LinkedList<>(), "TEST");
Map<String, AlgorithmConfiguration> loadBalancers =
Collections.singletonMap("TEST", new AlgorithmConfiguration("TEST", new
Properties()));
return new ReadwriteSplittingRuleConfiguration(new
LinkedList<>(Arrays.asList(fooDataSourceGroupConfig,
barDataSourceGroupConfig)), loadBalancers);
}
