sandynz commented on PR #38352:
URL: https://github.com/apache/shardingsphere/pull/38352#issuecomment-4010684372
> I investigated Solution 2 and updated this PR in that direction.
>
> What changed:
>
> * `prepare-e2e-artifacts` still performs the single checkout, but now also
creates a source snapshot with `git archive HEAD` and uploads it as an artifact
> * `e2e-sql-smoke`, `detect-remaining-matrix`, and `e2e-sql-stage2` no
longer run `actions/checkout`
> * those downstream jobs now download and restore the same source snapshot
before using the local workflow resources and running tests
> * the earlier explicit `ref` overrides in `detect-and-generate-matrix` /
`prepare-e2e-artifacts` were removed, so those steps are back to the default
checkout behavior
>
> The intent is to avoid repeated late fetches of the PR synthetic merge ref
in downstream jobs, while keeping the workflow scope limited to E2E-SQL.
>
> The new patch is pushed in commit `767f28bf`.
LGTM
If `e2e-sql-source-snapshot` artifact size could be smaller, then it could
be better.
I found the uploaded `e2e-sql-source-snapshot.tar.gz.zip` cost `109 MB`. And
I downloaded it to local, `docs/` cost `121M` and it's not necessary for `mvn
install` in e2e-sql, so could we exclude `docs/` on `git archive`? To save
storage, upload/download artifact time, restore source snapshot time.
```
% du -h -d 1 e2e-sql-source-snapshot
8.7M e2e-sql-source-snapshot/database
7.2M e2e-sql-source-snapshot/infra
4.7M e2e-sql-source-snapshot/proxy
30M e2e-sql-source-snapshot/test
2.4M e2e-sql-source-snapshot/mode
48K e2e-sql-source-snapshot/jdbc-dialect
7.7M e2e-sql-source-snapshot/features
464K e2e-sql-source-snapshot/distribution
1.1M e2e-sql-source-snapshot/agent
121M e2e-sql-source-snapshot/docs
7.8M e2e-sql-source-snapshot/parser
1.1M e2e-sql-source-snapshot/jdbc
76K e2e-sql-source-snapshot/.codex
8.0K e2e-sql-source-snapshot/.mvn
472K e2e-sql-source-snapshot/examples
180K e2e-sql-source-snapshot/.github
8.9M e2e-sql-source-snapshot/kernel
20K e2e-sql-source-snapshot/.idea
124K e2e-sql-source-snapshot/src
202M e2e-sql-source-snapshot
```
How do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
