zhaojinchao95 commented on PR #38670:
URL: https://github.com/apache/shardingsphere/pull/38670#issuecomment-4385503270
It can now be marked as Merge Verdict: Mergeable.
Decision
- Merge Verdict: Mergeable
- Reviewed Scope: the 6 version-upgrade files in the latest PR head
6be3ced5168, plus the follow-up fix in
[.github/workflows/nightly-e2e-sql.yml:83](/Users/zhaojinchao/Documents/ss-workspace/shardingsphere/.github/workflows/nightly-e2e-sql.yml:83).
- Not Reviewed Scope: GitHub remote CI detail pages and manual review
threads were not directly inspected; no real MySQL passthrough runtime test was
executed.
- Need Expert Review: No
Basis
- The previous blocker has been closed: the MySQL passthrough override in
the workflow has been updated from 8.3.0 to 8.4.0, and it is now aligned with
[pom.xml:128](/Users/zhaojinchao/Documents/ss-workspace/shardingsphere/pom.xml:128),
the example template,
and the CDC/Migration documentation.
- After re-scanning the relevant scope, there is no remaining 8.3.0 MySQL
connector version override in the reviewed files.
- The 8.4.0 jar still contains the key entry classes currently used by
ShardingSphere, so there is no visible direct API breakage risk.
- Most importantly, ./mvnw -pl proxy/bootstrap -am -DskipTests -DskipITs
-Dspotless.skip=true compile completed successfully, covering the affected
dependency graph and the Proxy/MySQL-related modules. During this run, there
was no MySQL 8.4.0-related
dependency convergence issue, missing class issue, or compile failure.
Pre-merge checks
- Version consistency check passed.
- Scoped compile on the affected build graph passed.
- The change is still limited to dependency version alignment plus
documentation/workflow synchronization, with no unrelated modifications
introduced.
Commands
- rg -n
"mysql-connector-java.version=8\.[0-9]+\.[0-9]+|mysql-connector-j-8\.[0-9]+\.[0-9]+|<mysql-connector-java.version>8\.[0-9]+\.[0-9]+"
.github docs examples pom.xml ... (exit 0)
- git status --short (exit 0)
- git diff --stat (exit 0)
- ./mvnw -pl proxy/bootstrap -am -DskipTests -DskipITs
-Dspotless.skip=true compile (exit 0)
Short conclusion: this revision has resolved the previous semantic
inconsistency, and the most relevant local compile verification has passed, so
it is mergeable. Self-check result: the conclusion was refreshed against the
latest state, and no remaining
merge blocker was found.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
