menghaoranss commented on PR #38672: URL: https://github.com/apache/shardingsphere/pull/38672#issuecomment-4386620650
Merge Verdict: Mergeable Reviewed Scope Latest head of PR #38672: c11cbf02373becf6796f54079e8684b39c9435bd All 6 changed files (IdentifierScope, ShardingSphereSchema, DatabaseIdentifierContext*, and 2 related test classes) Focused re-check on your new heterogeneous-detection fix and mixed-storage counterexample coverage Not Reviewed Scope No end-to-end JDBC/Proxy integration rerun in real deployment topology (review is code + unit-test level) Need Expert Review No (normal infra/metadata maintainer review is sufficient) Why this is now mergeable Root cause is now actually fixed: Heterogeneous detection no longer depends on a single findFirst() storage type. It now evaluates all storage types via isHeterogeneous(protocolType, getStorageDatabaseTypes(...)), which closes the mixed-storage false-negative path. Regression-risk controls are in place: Added mixed-storage test where first storage matches protocol but another differs. Added order-independence test (MySQL-first vs Oracle-first). Homogeneous disabled-path assertions are still present. Lookup semantics remain safe: Physical index remains first-priority, logical fallback second, so same-name shadowing behavior does not regress. Pre-merge note Unit tests and checkstyle for the touched module are aligned with the fix. GitHub statuses API for the head SHA currently returns empty in this check; please confirm PR CI panel is green before merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
