menghaoranss commented on PR #38711:
URL: https://github.com/apache/shardingsphere/pull/38711#issuecomment-4533799086
1. Decision block
`Merge Verdict: Mergeable`
- `Reviewed Scope`:
- Config key removal and reference cleanup in:
-
[ConfigurationPropertyKey.java](/Users/haoran/Project/shardingsphere/infra/common/src/main/java/org/apache/shardingsphere/infra/config/props/ConfigurationPropertyKey.java#L136)
- `mode/core` changes in `MetaDataContextsFactory`,
`LocalConfigurationMetaDataContextsInitFactory`,
`RegisterCenterMetaDataContextsInitFactory`, `MetaDataPersistFacade`, and
`DatabaseMetaDataPersistFacade`
- Synchronized test and output updates: `show_dist_variables`, proxy
backend/frontend unit tests, mode/core unit tests, renamed/removed test classes
- `Not Reviewed Scope`:
- Production-like rolling-upgrade runtime verification (not executed
locally in this review round)
- `Need Expert Review`: No (you explicitly confirmed this config and code
path are unused and should be removed)
2. Basis
- Root-cause alignment: the PR goal is to remove the useless
`persist-schemas-to-repository-enabled` key; the patch consistently removes
reads and conditional branches and converges to one metadata persistence path.
- Change consistency: production code, unit tests, E2E dataset, and DistSQL
variable output were updated together (variable count changed from 24 to 23).
- Risk profile: no new dependencies, no SQL parser semantic changes, and no
parser-dialect family impact; changes are scoped to metadata persistence-path
simplification and dead-config cleanup.
- The prior compatibility uncertainty is resolved by your explicit
confirmation that this config/branch is obsolete and should be deleted.
3. Pre-merge checks
- Latest PR head reviewed: `48f7256de799fd93aa9fcf0157d7eda401a3df6b`.
- Visible CI signal is green (check-runs reported success).
- Scope matches the PR intent; no unrelated functional changes were
identified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
