strongduanmu commented on PR #38730:
URL: https://github.com/apache/shardingsphere/pull/38730#issuecomment-4553386450
### Decision
- **Merge Verdict: Mergeable**
- **Reviewed Scope:** PR latest head `6d6a4fbb`; `test/it/parser` TCL
parser assertion classes and XML cases for `SET TRANSACTION`, `RELEASE
SAVEPOINT`, and the added MySQL `START TRANSACTION` supported case.
- **Not Reviewed Scope:** Full Maven build and all parser ITs were not
rerun locally in this review round; Proxy/JDBC runtime behavior was not
reviewed because this PR changes parser test assets only.
- **Need Expert Review:** No extra expert review required from the current
diff.
### Basis
- The PR adds concrete assertion coverage for `SetTransactionStatement`
scope, isolation level, and access mode, replacing previously empty test
expectations with field-level checks.
- The PR adds assertion coverage for `ReleaseSavepointStatement` savepoint
name and wires the new test case type into the TCL parser assertion path.
- The changed files are limited to parser IT test infrastructure and XML
test data; no production parser grammar, visitor logic, runtime path,
dependency manifest, or shared execution code is changed.
- Dialect-family risk is low for this diff because it validates existing
parser behavior instead of changing SQL parsing behavior.
- No `ConcurrentHashMap#computeIfAbsent` change is present in the diff.
### Pre-Merge Checks
- GitHub checks for the latest head `6d6a4fbb` are completed as success or
skipped.
- Local SQL parser verification was reported as passed.
- Recommended final confirmation before merge: keep the existing CI green
on the latest head.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
