terrymanu commented on PR #38742: URL: https://github.com/apache/shardingsphere/pull/38742#issuecomment-4561020120
### Decision - **Merge Verdict: Mergeable** - **Reviewed Scope:** Latest PR head `85214457271b33a64859dcac7419c210d93c502f`; local merge-base `5d2588c827cf3c6e8c161ab2c18baa8cea622f10`; GitHub `/pulls/38742/files` matched local `git diff apache/master...apache/pr/38742` with one file: `RELEASE-NOTES.md:22`. - **Not Reviewed Scope:** GitHub Actions/check-run status, full release packaging, and runtime behavior of the already-merged implementation PR beyond using #38561 as release-note evidence. - **Need Expert Review:** No. ### Basis - The PR is a focused release-note-only update for the already merged #38561 fix, which is in the `5.5.4` milestone. - The new entry is under `Release 5.5.4` / `Bug Fixes`, which matches the linked PR type and user-visible impact. - The wording is accurate and user-oriented: #38561 fixes Etcd cluster mode delete-event handling so dropped rule metadata is removed from in-memory metadata instead of being treated as an add/update path. - No production code, parser logic, shared execution path, API/SPI, dependency manifest, config, or high-frequency Proxy/JDBC DML/DQL path is changed. - I found no unrelated changes, no duplicate #38561 release-note entry, and no scope-boundary mismatch. - Adversarial pass checked for overclaiming, wrong release section, duplicate entry, and stale/unmerged referenced PR risk; no unresolved risk remained. ### Verification - `git diff --name-status apache/master...apache/pr/38742` matched GitHub `/pulls/38742/files`: only `RELEASE-NOTES.md`. - `git show apache/pr/38742:RELEASE-NOTES.md | rg -n "#38561|Etcd cluster|rule metadata not removed"` found the new entry at `RELEASE-NOTES.md:22`. - `git show apache/master:RELEASE-NOTES.md | rg -n "#38561|Etcd cluster|rule metadata not removed"` found no pre-existing duplicate entry. - `./mvnw -N spotless:check -Pcheck -T1C` passed with exit code 0. - Unit tests and Checkstyle were not run because this PR only changes a Markdown release note and does not touch Java production/test code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
