terrymanu commented on PR #38743:
URL: https://github.com/apache/shardingsphere/pull/38743#issuecomment-4561235644
### Review Result
- **Merge Verdict: Mergeable**
- Reviewed latest head: `d41c1593323266b062ebf8592de1752f9e294952`
- Base: `e0e8c2ac1526075f4db46f681fa5487242c271ef`
- Merge base: `e0e8c2ac1526075f4db46f681fa5487242c271ef`
- GitHub `/pulls/38743/files` matches the local triple-dot diff: 6 files.
- CI status was not used.
- Expert review required: No.
### Review Summary
- Removing obsolete design documents under `docs/mcp` is reasonable. They
should not continue to represent the current MCP public surface.
- Removing `MCPDocumentationContractTest` is reasonable. README/design
documents should not be treated as unit-test contracts.
- Keeping MCP Registry metadata validation in `mcp/registry` fits the module
boundary.
- Negative tests now cover `isRequired`, `isSecret`, and `format`
environment-variable shape checks.
- The `isSecret` branch now reports `isSecret` correctly instead of
`isRequired`.
### Risk Scan
- This PR does not touch SQL parser, routing, JDBC/Proxy high-frequency
execution paths, SPI/API, dependencies, or config format.
- The impact is limited to MCP documentation cleanup and MCP Registry
metadata validation.
- No unrelated changes were found.
- After deleting the bootstrap documentation test, the bootstrap module test
suite still passes.
### Verification
- `./mvnw -pl mcp/registry -am -DskipITs -Dspotless.skip=true
-Dtest=MCPRegistryMetadataCommandTest -Dsurefire.failIfNoSpecifiedTests=false
test -B -ntp`
- Passed, 22 tests, 0 failures
- `./mvnw -pl mcp/bootstrap -am -DskipITs -Dspotless.skip=true test -B -ntp`
- Passed, bootstrap 263 tests, 0 failures
- `./mvnw checkstyle:check -Pcheck -T1C`
- Passed
- `./mvnw spotless:check -Pcheck -T1C`
- Passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
