terrymanu commented on PR #38780:
URL: https://github.com/apache/shardingsphere/pull/38780#issuecomment-4604069787
### Decision
- **Merge Verdict: Mergeable**
- **Reviewed Scope:** Latest PR head
`e90fdae1fa5c1e193a4a66366e00113d83c7ff8f`, merge base
`4a6cb6bd3fbac1c162b6bc6cc5a6cdc81933cff3`. Reviewed the 8 documentation files
reported by GitHub `/pulls/38780/files`.
- **Not Reviewed Scope:** CI/check-run status was intentionally not
considered. No runtime smoke test was needed because the PR changes
documentation only.
- **Need Expert Review:** No specialized parser, concurrency, security,
dependency, or performance review is required for this docs-only change.
### Basis
- The previous deployment-boundary blocker is fixed. `runtimeDatabases` now
distinguishes ShardingSphere-Proxy logical databases for ShardingSphere
rule/plugin workflows from direct JDBC databases for general metadata, metadata
search, and controlled SQL capabilities.
- The PR consistently reframes AI application integration around MCP clients
rather than existing LLM clients.
- Capability documentation now aligns with the actual MCP public surface,
including `tools/list`, `resources/list`, `resources/templates/list`,
`prompts/list`, `shardingsphere://capabilities`, and
`shardingsphere://databases/{database}/capabilities`.
- Troubleshooting now owns the connection failure categories, while
capability documentation keeps connectivity validation at the tool-contract
level.
- The remaining Proxy-only wording in feature plugin documentation is
appropriate because those feature workflows depend on ShardingSphere rules and
DistSQL, not direct physical-database access.
- The PR is documentation-only and does not change production code, tests,
dependencies, SPI contracts, SQL parser behavior, runtime routing, or
high-frequency execution paths.
### Verification
- Confirmed the GitHub PR file list matches the local merge-base diff.
- Confirmed the changed files are limited to ShardingSphere-MCP user manual
documentation.
- Confirmed the English and Chinese deployment pages now share the corrected
capability boundary.
- Repository gates on the fixed documentation version passed:
- `./mvnw spotless:apply -Pcheck -T1C`
- `./mvnw checkstyle:check -Pcheck -T1C`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
