menghaoranss commented on PR #38774:
URL: https://github.com/apache/shardingsphere/pull/38774#issuecomment-4608105774
### Decision
- **Merge Verdict: Mergeable**
- **Reviewed Scope:** Latest PR head with added targeted regression coverage
for the changed shared metadata lookup paths.
- **Not Reviewed Scope:** Local execution of some Mockito-inline-based tests
may still depend on the reviewer’s JDK attach capability; no remaining
code-level defect was identified in the PR itself.
- **Need Expert Review:** No
### Positive Feedback
- The optimization keeps the refactor focused on the metadata lookup hot
path without expanding scope unnecessarily.
- The PR now adds direct regression coverage for the affected shared callers:
- `QueryContext#getUsedDatabases()` success and unknown-database failure
- `ProxySQLComQueryParser` empty database-name fallback path
- The previously identified test issue was limited to assertion style and
has been corrected without changing production behavior.
### Residual Risk
- Remaining verification differences, if any, are expected to be
environment-related (Mockito inline attach / JDK setup) rather than caused by
the patch logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
