This is an automated email from the ASF dual-hosted git repository.

strongduanmu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 908ff08cea2 Remove redundant parameter replay invocations (#38793)
908ff08cea2 is described below

commit 908ff08cea2925d387983f42580c5fc493fe3228
Author: ZhangCheng <[email protected]>
AuthorDate: Thu Jun 4 10:50:16 2026 +0800

    Remove redundant parameter replay invocations (#38793)
---
 .../adapter/AbstractPreparedStatementAdapter.java  | 23 ++--------------------
 1 file changed, 2 insertions(+), 21 deletions(-)

diff --git 
a/jdbc/src/main/java/org/apache/shardingsphere/driver/jdbc/adapter/AbstractPreparedStatementAdapter.java
 
b/jdbc/src/main/java/org/apache/shardingsphere/driver/jdbc/adapter/AbstractPreparedStatementAdapter.java
index 61d5b0bee00..8948845e916 100644
--- 
a/jdbc/src/main/java/org/apache/shardingsphere/driver/jdbc/adapter/AbstractPreparedStatementAdapter.java
+++ 
b/jdbc/src/main/java/org/apache/shardingsphere/driver/jdbc/adapter/AbstractPreparedStatementAdapter.java
@@ -38,7 +38,6 @@ import java.sql.Time;
 import java.sql.Timestamp;
 import java.util.ArrayList;
 import java.util.Calendar;
-import java.util.LinkedList;
 import java.util.List;
 
 /**
@@ -46,8 +45,6 @@ import java.util.List;
  */
 public abstract class AbstractPreparedStatementAdapter extends 
AbstractUnsupportedOperationPreparedStatement {
     
-    private final List<PreparedStatementInvocationReplayer> 
setParameterMethodInvocations = new LinkedList<>();
-    
     @Getter
     private final List<Object> parameters = new ArrayList<>();
     
@@ -275,30 +272,14 @@ public abstract class AbstractPreparedStatementAdapter 
extends AbstractUnsupport
     }
     
     protected final void replaySetParameter(final PreparedStatement 
preparedStatement, final List<Object> params) throws SQLException {
-        setParameterMethodInvocations.clear();
-        addParameters(params);
-        for (PreparedStatementInvocationReplayer each : 
setParameterMethodInvocations) {
-            each.replayOn(preparedStatement);
-        }
-    }
-    
-    private void addParameters(final List<Object> params) {
-        int i = 0;
+        int index = 0;
         for (Object each : params) {
-            int index = ++i;
-            setParameterMethodInvocations.add(preparedStatement -> 
preparedStatement.setObject(index, each));
+            preparedStatement.setObject(++index, each);
         }
     }
     
     @Override
     public final void clearParameters() {
         parameters.clear();
-        setParameterMethodInvocations.clear();
-    }
-    
-    @FunctionalInterface
-    private interface PreparedStatementInvocationReplayer {
-        
-        void replayOn(PreparedStatement preparedStatement) throws SQLException;
     }
 }

Reply via email to