swayamraina commented on a change in pull request #6187:
URL: https://github.com/apache/shardingsphere/pull/6187#discussion_r449001831
##########
File path:
shardingsphere-control-panel/shardingsphere-orchestration/shardingsphere-orchestration-core/shardingsphere-orchestration-core-facade/src/main/java/org/apache/shardingsphere/orchestration/core/facade/ShardingOrchestrationFacade.java
##########
@@ -81,7 +81,7 @@
private final ShardingOrchestrationListenerManager listenerManager;
- public ShardingOrchestrationFacade(final OrchestrationConfiguration
orchestrationConfig, final Collection<String> shardingSchemaNames) {
+ public ShardingOrchestrationFacade(final OrchestrationConfiguration
orchestrationConfig, final Collection<String> shardingSchemaNames, final int
identifier) {
Review comment:
keeping this as `instanceId` also does not seem to be justified since
this is only a part of the actual `instanceId`.
Should we keep this as `instanceSubId`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
