dongzl commented on a change in pull request #1077:
URL:
https://github.com/apache/shardingsphere-elasticjob/pull/1077#discussion_r454984334
##########
File path:
elasticjob-lite/elasticjob-lite-spring-boot-starter/src/main/java/org/apache/shardingsphere/elasticjob/lite/boot/ElasticJobLiteAutoConfiguration.java
##########
@@ -50,9 +50,9 @@
@EnableConfigurationProperties(ElasticJobProperties.class)
@Setter
public class ElasticJobLiteAutoConfiguration implements
ApplicationContextAware {
-
+
Review comment:
Please keep the white space.
##########
File path:
elasticjob-lite/elasticjob-lite-spring-boot-starter/src/main/java/org/apache/shardingsphere/elasticjob/lite/boot/ElasticJobLiteAutoConfiguration.java
##########
@@ -50,9 +50,9 @@
@EnableConfigurationProperties(ElasticJobProperties.class)
@Setter
public class ElasticJobLiteAutoConfiguration implements
ApplicationContextAware {
-
+
private ApplicationContext applicationContext;
-
+
Review comment:
Please keep the white space.
##########
File path:
elasticjob-lite/elasticjob-lite-spring-boot-starter/src/main/java/org/apache/shardingsphere/elasticjob/lite/boot/ElasticJobLiteAutoConfiguration.java
##########
@@ -68,7 +68,7 @@ public void createJobBootstrapBeans() throws
ClassNotFoundException {
registerClassedJobs(elasticJobProperties, beanFactory, registryCenter,
tracingConfiguration);
registerTypedJobs(elasticJobProperties, beanFactory, registryCenter,
tracingConfiguration);
}
-
Review comment:
The same to above.
##########
File path:
elasticjob-lite/elasticjob-lite-spring-boot-starter/src/main/java/org/apache/shardingsphere/elasticjob/lite/boot/ElasticJobLiteAutoConfiguration.java
##########
@@ -81,7 +81,7 @@ private TracingConfiguration getTracingConfiguration() {
"More than one
[org.apache.shardingsphere.elasticjob.tracing.api.TracingConfiguration] beans
found. "
+ "Consider disabling
[org.apache.shardingsphere.elasticjob.tracing.boot.ElasticjobTracingAutoConfiguration].");
}
-
+
Review comment:
The same to above.
##########
File path:
elasticjob-lite/elasticjob-lite-spring-boot-starter/src/main/java/org/apache/shardingsphere/elasticjob/lite/boot/ElasticJobLiteAutoConfiguration.java
##########
@@ -97,8 +97,8 @@ private void registerClassedJobs(final ElasticJobProperties
elasticJobProperties
}
}
}
-
- private void registerTypedJobs(final ElasticJobProperties
elasticJobProperties, final SingletonBeanRegistry beanFactory,
+
Review comment:
The same to above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
