feiweihy commented on pull request #6366: URL: https://github.com/apache/shardingsphere/pull/6366#issuecomment-660471503
> @feiweihy Hi Got it, thanks for your feedback. Since @yu199195 also gave us a double-check and the unit test seems a difficult block. Maybe we can firstly remove the unit test and merge this one. After that, we can consider the unit test. What do you think? Unit test has been removed. It seems impossible to run a unit test just depending on mocking database. The unit test which has been removed I provided can run successfully for this bug by importing external ojdbc lib. But in ci test environment, we can not import the lib. This is a paradox. I have installed the package for the code I modified, and use it in our test environment for a project. The test environment has not been abnormal these days. If @yu199195 also give a check what I modified is correct, I think I have really fix the bug. Thank you for your preciseness! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
