whg903 commented on issue #6839:
URL: https://github.com/apache/shardingsphere/issues/6839#issuecomment-675791209


   I feel disappointed for won't fix this bug. 
   Version 4.0.0 is ok, but 4.1.0+ has this problem, that's important for unit 
test.
   Why not change "String databaseType" to "DatabaseType databaseType" of 
TableMetaDataLoader.load and ColumnMetaDataLoader.load, then can use 
"instanceof BranchDatabaseType" and "BranchDatabaseType.getTrunkDatabaseType" 
to get actual database type info.
   If H2 mysql mode is not supported,  what's  the use of 
H2DatabaseType.getTrunkDatabaseType?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to