terrymanu commented on a change in pull request #50:
URL:
https://github.com/apache/shardingsphere-elasticjob-ui/pull/50#discussion_r495066590
##########
File path:
shardingsphere-elasticjob-lite-ui/shardingsphere-elasticjob-lite-ui-backend/src/main/java/org/apache/shardingsphere/elasticjob/lite/ui/domain/DataSourceFactory.java
##########
@@ -25,14 +27,15 @@
/**
* Dynamic data source factory.
*/
+@NoArgsConstructor(access = AccessLevel.PRIVATE)
public final class DataSourceFactory {
/**
* Create a DataSource.
* @param config event trace data source config
* @return data source
*/
- public static DataSource createDataSource(final
EventTraceDataSourceConfiguration config) {
+ public static DataSource createDataSource(final
EventTraceDataSourceConfiguration config) throws ClassNotFoundException {
Review comment:
Please add java doc on throw exception
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
