TanveshT commented on a change in pull request #7888:
URL: https://github.com/apache/shardingsphere/pull/7888#discussion_r512383167
##########
File path:
shardingsphere-governance/shardingsphere-governance-repository/shardingsphere-governance-repository-provider/shardingsphere-governance-repository-etcd/src/main/java/org/apache/shardingsphere/governance/repository/etcd/EtcdRepository.java
##########
@@ -109,11 +109,12 @@ public void watch(final String key, final
DataChangedEventListener dataChangedEv
for (WatchEvent each : response.getEvents()) {
ChangedType changedType = getEventChangedType(each);
if (ChangedType.IGNORED != changedType) {
- dataChangedEventListener.onChange(new
DataChangedEvent(each.getKeyValue().getKey().toString(Charsets.UTF_8),
each.getKeyValue().getValue().toString(Charsets.UTF_8), changedType));
+ dataChangedEventListener.onChange(new
DataChangedEvent(each.getKeyValue().getKey().toString(StandardCharsets.UTF_8)
+ ,
each.getKeyValue().getValue().toString(StandardCharsets.UTF_8), changedType));
Review comment:
Nothing else @menghaoranss. Will make the that commit soon
##########
File path:
shardingsphere-governance/shardingsphere-governance-repository/shardingsphere-governance-repository-provider/shardingsphere-governance-repository-etcd/src/main/java/org/apache/shardingsphere/governance/repository/etcd/EtcdRepository.java
##########
@@ -109,11 +109,12 @@ public void watch(final String key, final
DataChangedEventListener dataChangedEv
for (WatchEvent each : response.getEvents()) {
ChangedType changedType = getEventChangedType(each);
if (ChangedType.IGNORED != changedType) {
- dataChangedEventListener.onChange(new
DataChangedEvent(each.getKeyValue().getKey().toString(Charsets.UTF_8),
each.getKeyValue().getValue().toString(Charsets.UTF_8), changedType));
+ dataChangedEventListener.onChange(new
DataChangedEvent(each.getKeyValue().getKey().toString(StandardCharsets.UTF_8)
+ ,
each.getKeyValue().getValue().toString(StandardCharsets.UTF_8), changedType));
Review comment:
Nothing else @menghaoranss. Will make that commit soon
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
