terrymanu commented on a change in pull request #8317:
URL: https://github.com/apache/shardingsphere/pull/8317#discussion_r529476601



##########
File path: 
shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/spi/typed/TypedSPIRegistry.java
##########
@@ -64,4 +64,12 @@
         }
         throw new ServiceProviderNotFoundException(typedSPIClass);
     }
+    
+    private static <T extends TypedSPI> void convertPropertiesValueType(final 
Properties props, final T result) {

Review comment:
       input param should not name as `result`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to