jingshanglu edited a comment on issue #7880: URL: https://github.com/apache/shardingsphere/issues/7880#issuecomment-734194083
@lwtdev Now, we can do it step by step, `Expr` is more important, we can fix assert of `Expr` first, - **Questions About** `ExpectedWhereClause` 1. Now , i think `ExpectedAndPredicate` and `ExpectedPredicate` in `ExpectedWhereClause` is unreasonable, maybe `ExpectedExpr` is better, and add some subclass for it, like `ExpectedInExpression`, `ExpectedNotExpression` and so on. Because of the redesign of the `Expr` domain model, we need to design reasonably UT for `Expr`, How do you think? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
