tristaZero commented on issue #8570:
URL: https://github.com/apache/shardingsphere/issues/8570#issuecomment-745037915


   IMO, there are two methods to deal with this one.
   
   ### DataSourceConfiguration
   Like `SKIPPED_PROPERTY_NAMES`, it is possible to add a Map<DriverType, 
List<Properties>> to set an appropriate value for these particular properties. 
But this way will make `DataSourceConfiguration` senses `Driver Types`.
   
   ### HikariJDBCParameterDecorator
   That's a specific class to decorate properties to `HikariCP`, a proper place 
to do some exclusive works for a certain Driver pool. So we can give 
`exceptionOverrideClassName` a proper value here. Meanwhile, we have to move 
this class from `proxy` module to maybe `infra` module.
   
   For me, I prefer the first one to avoid the impact of other setting 
operations in `HikariJDBCParameterDecorator`. What do you think?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to