jingshanglu commented on a change in pull request #8604:
URL: https://github.com/apache/shardingsphere/pull/8604#discussion_r543167223
##########
File path:
shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/asserts/segment/expression/ExpressionAssert.java
##########
@@ -65,7 +87,7 @@ public static void assertParameterMarkerExpression(final
SQLCaseAssertContext as
*/
public static void assertLiteralExpression(final SQLCaseAssertContext
assertContext,
final LiteralExpressionSegment
actual, final ExpectedLiteralExpression expected) {
- assertNotNull(assertContext.getText("Expected literal expression
should exist."));
+ assertNotNull(assertContext.getText("Expected literal expression
should exist."), expected);
Review comment:
@lwtdev Like this, maybe it's better to go to assert actual based on
expect.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
