menghaoranss commented on pull request #9190: URL: https://github.com/apache/shardingsphere/pull/9190#issuecomment-768784170
> 1. Do we have unit tests to cover the checking for `Map<>`? I know `Prosperities` test has been added. > 2. Do you think it is better to change ` YamlEngine.unmarshal(yamlContent, YamlRuleConfigurationWrap.class, Collections.singletonList(YamlRuleConfigurationWrap.class))` to `YamlEngine.unmarshal(yamlContent, YamlRuleConfigurationWrap.class)`? Therefore we can get `Collections.singletonList(YamlRuleConfigurationWrap.class)` inner `YamlEngine.unmarshal` 1. YamlEnginTest.java assertUnmarshalWithYamlContent(); assertUnmarshalMapWithIllegalClasses(); assertUnmarshalMapWithAcceptClasses() 2. I agree with your suggestion，but unmarshal(final String yamlContent, final Class<T> classType) method already exists in YamlEngin.java, unless use another method name instead. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
