[shardingsphere-elasticjob] branch master updated: Close dataSource in RDBJobEventStorageTest when each test finishes (#1838)

[wuweijie]

This is an automated email from the ASF dual-hosted git repository.

wuweijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere-elasticjob.git


The following commit(s) were added to refs/heads/master by this push:
     new bb23820  Close dataSource in RDBJobEventStorageTest when each test 
finishes (#1838)
bb23820 is described below

commit bb23820c44232ac722dc3b53cdf88d61745fb003
Author: lzx404243 <lzx404...@hotmail.com>
AuthorDate: Sat Feb 27 06:38:22 2021 -0600

    Close dataSource in RDBJobEventStorageTest when each test finishes (#1838)
    
    * Close dataSource in RDBJobEventStorageTest when each test finishes
    
    * Fix checkstyle
---
 .../elasticjob/tracing/rdb/storage/RDBJobEventStorageTest.java | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git 
a/elasticjob-ecosystem/elasticjob-tracing/elasticjob-tracing-rdb/src/test/java/org/apache/shardingsphere/elasticjob/tracing/rdb/storage/RDBJobEventStorageTest.java
 
b/elasticjob-ecosystem/elasticjob-tracing/elasticjob-tracing-rdb/src/test/java/org/apache/shardingsphere/elasticjob/tracing/rdb/storage/RDBJobEventStorageTest.java
index d63b9c3..15ac7d3 100644
--- 
a/elasticjob-ecosystem/elasticjob-tracing/elasticjob-tracing-rdb/src/test/java/org/apache/shardingsphere/elasticjob/tracing/rdb/storage/RDBJobEventStorageTest.java
+++ 
b/elasticjob-ecosystem/elasticjob-tracing/elasticjob-tracing-rdb/src/test/java/org/apache/shardingsphere/elasticjob/tracing/rdb/storage/RDBJobEventStorageTest.java
@@ -22,6 +22,7 @@ import 
org.apache.shardingsphere.elasticjob.tracing.event.JobExecutionEvent;
 import org.apache.shardingsphere.elasticjob.tracing.event.JobStatusTraceEvent;
 import 
org.apache.shardingsphere.elasticjob.tracing.event.JobStatusTraceEvent.Source;
 import 
org.apache.shardingsphere.elasticjob.tracing.event.JobStatusTraceEvent.State;
+import org.junit.After;
 import org.junit.Before;
 import org.junit.Test;
 
@@ -38,10 +39,12 @@ import static org.junit.Assert.assertTrue;
 public final class RDBJobEventStorageTest {
     
     private RDBJobEventStorage storage;
+
+    private BasicDataSource dataSource;
     
     @Before
     public void setup() throws SQLException {
-        BasicDataSource dataSource = new BasicDataSource();
+        dataSource = new BasicDataSource();
         dataSource.setDriverClassName(org.h2.Driver.class.getName());
         dataSource.setUrl("jdbc:h2:mem:job_event_storage");
         dataSource.setUsername("sa");
@@ -49,6 +52,11 @@ public final class RDBJobEventStorageTest {
         storage = new RDBJobEventStorage(dataSource);
     }
     
+    @After
+    public void teardown() throws SQLException {
+        dataSource.close();
+    }
+
     @Test
     public void assertAddJobExecutionEvent() {
         assertTrue(storage.addJobExecutionEvent(new 
JobExecutionEvent("localhost", "127.0.0.1", "fake_task_id", "test_job", 
JobExecutionEvent.ExecutionSource.NORMAL_TRIGGER, 0)));