terrymanu commented on a change in pull request #9750:
URL: https://github.com/apache/shardingsphere/pull/9750#discussion_r598493671
##########
File path:
shardingsphere-scaling/shardingsphere-scaling-bootstrap/src/test/java/org/apache/shardingsphere/scaling/web/HttpServerInitializerTest.java
##########
@@ -45,9 +42,8 @@
private ChannelPipeline channelPipeline;
@Before
- @SneakyThrows(ReflectiveOperationException.class)
public void setUp() {
- ReflectionUtil.setFieldValue(ScalingContext.getInstance(),
"serverConfig", new ServerConfiguration());
+ ServerConfigurationInitializer.init();
Review comment:
This change seem no relate with your PR, why to change it?
##########
File path:
shardingsphere-proxy/shardingsphere-proxy-bootstrap/src/test/java/org/apache/shardingsphere/proxy/initializer/impl/GovernanceBootstrapInitializerTest.java
##########
@@ -227,4 +227,10 @@ public void assertDecorateTransactionContexts() {
protected void prepareSpecifiedInitializer() {
setInitializer(new GovernanceBootstrapInitializer());
}
+
+ private StandardMetaDataContexts mockStandardMetaDataContexts() {
+ StandardMetaDataContexts standardMetaDataContexts =
mock(StandardMetaDataContexts.class);
+ when(standardMetaDataContexts.getProps()).thenReturn(new
ConfigurationProperties(new Properties()));
+ return standardMetaDataContexts;
+ }
Review comment:
Another PR fix NPE, so, could you revert the changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
