strongduanmu commented on a change in pull request #10956:
URL: https://github.com/apache/shardingsphere/pull/10956#discussion_r657643056
##########
File path:
shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/metadata/schema/builder/loader/dialect/OracleTableMetaDataLoader.java
##########
@@ -44,7 +44,7 @@
*/
public final class OracleTableMetaDataLoader implements
DialectTableMetaDataLoader {
- private static final String TABLE_META_DATA_SQL = "SELECT OWNER AS
TABLE_SCHEMA, TABLE_NAME, COLUMN_NAME, DATA_TYPE, IDENTITY_COLUMN %s FROM
ALL_TAB_COLUMNS WHERE OWNER = ?";
Review comment:
@xueshiji This field is added in Oracle 12.1 version, you can refer to
the
[document](https://docs.oracle.com/database/121/REFRN/GUID-F218205C-7D76-4A83-8691-BFD2AD372B63.htm#REFRN20277).
Therefore, the version judgment logic should be different from the COLLATION
field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
