totalo commented on pull request #11086:
URL: https://github.com/apache/shardingsphere/pull/11086#issuecomment-872280655
> This PR looks fine to me. Also, It is suggested to do some improvement in
the following code snippets. At least, the function names, i,e.,
`appendRemainTables`, `addRuleConfiguredTables` are not appropriate.
>
> ```
> // SchemaBuilder.java
>
> public static Map<TableMetaData, TableMetaData> build(final
SchemaBuilderMaterials materials) throws SQLException {
> Map<String, TableMetaData> actualTableMetaMap =
appendRemainTables(materials);
> Map<String, TableMetaData> logicTableMetaMap =
addRuleConfiguredTables(materials, actualTableMetaMap);
> return buildTableMetaDataMap(actualTableMetaMap,
logicTableMetaMap);
> }
> ```
yeah! let me see.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
