strongduanmu commented on a change in pull request #11385:
URL: https://github.com/apache/shardingsphere/pull/11385#discussion_r672989399
##########
File path:
shardingsphere-features/shardingsphere-encrypt/shardingsphere-encrypt-core/src/main/java/org/apache/shardingsphere/encrypt/rewrite/token/generator/impl/EncryptAlterTableTokenGenerator.java
##########
@@ -53,7 +53,7 @@ protected boolean isGenerateSQLTokenForEncrypt(final
SQLStatementContext sqlStat
result.addAll(getDropColumnTokens(tableName,
alterTableStatementContext.getSqlStatement().getDropColumnDefinitions()));
return result;
}
-
Review comment:
@arthasking123 Keep indents consistent with the previous one. Please
modify similar issues in other places.
##########
File path:
shardingsphere-features/shardingsphere-encrypt/shardingsphere-encrypt-core/src/main/java/org/apache/shardingsphere/encrypt/rewrite/token/pojo/EncryptAlterTableToken.java
##########
@@ -42,6 +43,9 @@ public EncryptAlterTableToken(final int startIndex, final int
stopIndex, final S
@Override
public String toString() {
+ if ("".equals(this.operationType) && "".equals(this.columnName)) {
Review comment:
Why add this logic?
##########
File path:
shardingsphere-test/shardingsphere-rewrite-test/src/test/resources/scenario/encrypt/case/alter_for_query_with_plain.xml
##########
@@ -41,4 +46,6 @@
<input sql="ALTER TABLE t_account_bak DROP COLUMN password , DROP
COLUMN id" />
<output sql="ALTER TABLE t_account_bak DROP COLUMN cipher_password ,
DROP COLUMN assisted_query_password , DROP COLUMN plain_password , DROP
COLUMN id" />
</rewrite-assertion>
+
Review comment:
Please remove redundant blank line.
##########
File path:
shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/segment/ddl/column/alter/ModifyColumnDefinitionSegment.java
##########
@@ -39,9 +39,11 @@
private final int stopIndex;
private final ColumnDefinitionSegment columnDefinition;
+
+ private String previousColumnName = "";
Review comment:
@arthasking123 Add a `ColumnDefinitionSegment newColumnDefinition` field
to handle this case is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
