justbk2015 commented on a change in pull request #11440:
URL: https://github.com/apache/shardingsphere/pull/11440#discussion_r677944068
##########
File path:
shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/communication/jdbc/datasource/factory/JDBCRawBackendDataSourceFactory.java
##########
@@ -62,7 +63,17 @@ public DataSource build(final String dataSourceName, final
DataSourceParameter d
config.setDriverClassName(driverClassName);
config.setJdbcUrl(dataSourceParameter.getUrl());
config.setUsername(dataSourceParameter.getUsername());
- config.setPassword(dataSourceParameter.getPassword());
+ String decryptPasswd = null;
+ try {
+ decryptPasswd = AlgorithmSecureFactory.getInstance()
+ .decryptBackend(dataSourceParameter.getPassword());
+ // CHECKSTYLE:OFF
+ } catch (final Exception ex) {
+ // CHECKSTYLE:ON
+ log.error("password decrypt failed:", ex);
+ return null;
Review comment:
this is no need repair,.
if password is null, proxy can't started. the log will record reason is
password decrypt failed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
