[GitHub] [shardingsphere] yx9o opened a new issue #11581: optimization Hard-coded string

Thu, 29 Jul 2021 21:17:43 -0700 


yx9o opened a new issue #11581:
URL: https://github.com/apache/shardingsphere/issues/11581


   Hi, I found the following database type values such as: `"H2", "MySQL", 
"PostgreSQL", "Oracle", "SQLServer", "SQL92"` There are hard-coded strings in a 
large number of classes (test Except for classes).
   
   Although these values will not be changed or incorrectly written, I still 
think it is better to use enumerations to replace strings, which is easier to 
manage and maintain.
   
   Welcome to leave a comment and discuss.
   
   Code screenshot:
   
   
![image](https://user-images.githubusercontent.com/12792261/127594773-92de7bcb-5545-4dc9-9b14-96b260c8d4ef.png)
   
![image](https://user-images.githubusercontent.com/12792261/127594911-f7196635-58c5-4614-8645-8b6b6566726a.png)
   
![image](https://user-images.githubusercontent.com/12792261/127595154-2c4319d7-d97f-421f-bcbb-de44c3ffe17e.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to