ThanoshanMV commented on pull request #11503: URL: https://github.com/apache/shardingsphere/pull/11503#issuecomment-890567921
> * Modified the `aggregationFunction` by adding [analyticClause](https://docs.oracle.com/en/database/oracle/oracle-database/19/sqlrf/Analytic-Functions.html#GUID-527832F7-63C0-4445-8C16-307FA5084056). Here's the documentation for existing aggregate functions: [MIN](https://docs.oracle.com/en/database/oracle/oracle-database/19/sqlrf/MIN.html#GUID-F7F04E18-1AD8-4D15-9491-4622AD847A74), [MAX](https://docs.oracle.com/en/database/oracle/oracle-database/19/sqlrf/MAX.html#GUID-E5372020-A6DA-44BF-93BE-DA8C3F74CD01), [SUM](https://docs.oracle.com/en/database/oracle/oracle-database/19/sqlrf/SUM.html#GUID-5610BE2C-CFE5-446F-A1F7-B924B5663220), [COUNT](https://docs.oracle.com/en/database/oracle/oracle-database/19/sqlrf/COUNT.html#GUID-AEF08B79-024D-4E3A-B362-9715FB011776), [AVG](https://docs.oracle.com/en/database/oracle/oracle-database/19/sqlrf/AVG.html#GUID-B64BCBF1-DAA0-4D88-9821-2C4D3FDE5E4A), [GROUPING](https://docs.oracle.com/en/database/oracle/oracle-database/19/sqlrf/GROUPING.html#GU ID-82E6084A-0BDF-4587-A40E-36899783F073). I made the above changes to successfully parse SQL case id `select_with_model_dimension` but after adding `modelExpr`, the parsing happens successfully using `modelExpr`'s `analyticFunction`  I think maybe we can remove the changes made to `aggregationFunction` rule and fix its changes in another PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
