strongduanmu commented on a change in pull request #11601:
URL: https://github.com/apache/shardingsphere/pull/11601#discussion_r682335729
##########
File path:
shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/main/java/org/apache/shardingsphere/sharding/route/strategy/ShardingStrategyFactory.java
##########
@@ -43,11 +43,13 @@
*
* @param shardingStrategyConfig sharding strategy configuration
* @param shardingAlgorithm sharding algorithm
+ * @param defaultShardingColumn default sharding column
* @return sharding strategy instance
*/
- public static ShardingStrategy newInstance(final
ShardingStrategyConfiguration shardingStrategyConfig, final ShardingAlgorithm
shardingAlgorithm) {
+ public static ShardingStrategy newInstance(final
ShardingStrategyConfiguration shardingStrategyConfig, final ShardingAlgorithm
shardingAlgorithm, final String defaultShardingColumn) {
if (shardingStrategyConfig instanceof
StandardShardingStrategyConfiguration && shardingAlgorithm instanceof
StandardShardingAlgorithm) {
- return new
StandardShardingStrategy(((StandardShardingStrategyConfiguration)
shardingStrategyConfig).getShardingColumn(), (StandardShardingAlgorithm)
shardingAlgorithm);
+ return new
StandardShardingStrategy(((StandardShardingStrategyConfiguration)
shardingStrategyConfig).getShardingColumn() == null
Review comment:
@tuichenchuxin `((StandardShardingStrategyConfiguration)
shardingStrategyConfig).getShardingColumn() == null` may be better.
##########
File path:
shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-core/src/main/java/org/apache/shardingsphere/sharding/rule/ShardingRule.java
##########
@@ -362,7 +366,9 @@ private boolean isShardingColumn(final TableRule tableRule,
final String columnN
private boolean isShardingColumn(final ShardingStrategyConfiguration
shardingStrategyConfig, final String columnName) {
if (shardingStrategyConfig instanceof
StandardShardingStrategyConfiguration) {
- return ((StandardShardingStrategyConfiguration)
shardingStrategyConfig).getShardingColumn().equalsIgnoreCase(columnName);
+ String shardingColumn = ((StandardShardingStrategyConfiguration)
shardingStrategyConfig).getShardingColumn() == null
Review comment:
@tuichenchuxin `null == ((StandardShardingStrategyConfiguration)
shardingStrategyConfig).getShardingColumn()` may be better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
