zjcnb commented on a change in pull request #11655:
URL: https://github.com/apache/shardingsphere/pull/11655#discussion_r683185968
##########
File path:
shardingsphere-test/shardingsphere-integration-scaling-test/shardingsphere-integration-scaling-test-mysql/src/test/java/org/apache/shardingsphere/integration/scaling/test/mysql/env/config/SourceConfiguration.java
##########
@@ -94,6 +94,6 @@ private static YamlRootRuleConfigurations
getShardingJdbcConfiguration(final Str
public static DataSource createHostDataSource(final Map<String,
YamlTableRuleConfiguration> tableRules) {
ShardingSphereJDBCDataSourceConfiguration configuration =
getHostConfiguration(tableRules);
return new ShardingSphereDataSource(new
YamlDataSourceConfigurationSwapper().swapToDataSources(configuration.getRootRuleConfigs().getDataSources()),
- new
YamlRuleConfigurationSwapperEngine().swapToRuleConfigurations(configuration.getRootRuleConfigs().getRules()),
null);
+ new
YamlRuleConfigurationSwapperEngine().swapToRuleConfigurations(configuration.getRootRuleConfigs().getRules()),
null, null);
Review comment:
The parameter comes from the user configuration, i don't sure real
value. By the way, if it is a null value, I will assign it a default value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
