menghaoranss commented on a change in pull request #11649:
URL: https://github.com/apache/shardingsphere/pull/11649#discussion_r683235301



##########
File path: 
shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/yaml/config/swapper/YamlDataSourceConfigurationSwapper.java
##########
@@ -67,6 +71,9 @@ public DataSourceConfiguration 
swapToDataSourceConfiguration(final Map<String, O
      */
     public Map<String, Object> swapToMap(final DataSourceConfiguration 
dataSourceConfig) {
         Map<String, Object> result = new 
HashMap<>(dataSourceConfig.getProps());
+        if (dataSourceConfig.getCustomPoolProps().isEmpty()) {

Review comment:
       Why put when `dataSourceConfig.getCustomPoolProps()` is empty?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to