vince7839 commented on a change in pull request #11626:
URL: https://github.com/apache/shardingsphere/pull/11626#discussion_r683297444
##########
File path:
shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/util/ExpressionBuilder.java
##########
@@ -50,13 +52,7 @@ public OrPredicateSegment extractAndPredicates() {
result.getAndPredicates().addAll(leftBuilder.extractAndPredicates().getAndPredicates());
result.getAndPredicates().addAll(rightBuilder.extractAndPredicates().getAndPredicates());
} else if (logicalOperator.isPresent() && LogicalOperator.AND ==
logicalOperator.get()) {
- ExpressionBuilder leftBuilder = new
ExpressionBuilder(((BinaryOperationExpression) expression).getLeft());
- ExpressionBuilder rightBuilder = new
ExpressionBuilder(((BinaryOperationExpression) expression).getRight());
- for (AndPredicate eachLeft :
leftBuilder.extractAndPredicates().getAndPredicates()) {
- for (AndPredicate eachRight :
rightBuilder.extractAndPredicates().getAndPredicates()) {
-
result.getAndPredicates().add(createAndPredicate(eachLeft, eachRight));
- }
- }
+ processAndExpression(result);
Review comment:
Do you mean changing the method of "processAndExpression()" to
"createAndPredicates()"?
##########
File path:
shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/util/ExpressionBuilder.java
##########
@@ -50,13 +52,7 @@ public OrPredicateSegment extractAndPredicates() {
result.getAndPredicates().addAll(leftBuilder.extractAndPredicates().getAndPredicates());
result.getAndPredicates().addAll(rightBuilder.extractAndPredicates().getAndPredicates());
} else if (logicalOperator.isPresent() && LogicalOperator.AND ==
logicalOperator.get()) {
- ExpressionBuilder leftBuilder = new
ExpressionBuilder(((BinaryOperationExpression) expression).getLeft());
- ExpressionBuilder rightBuilder = new
ExpressionBuilder(((BinaryOperationExpression) expression).getRight());
- for (AndPredicate eachLeft :
leftBuilder.extractAndPredicates().getAndPredicates()) {
- for (AndPredicate eachRight :
rightBuilder.extractAndPredicates().getAndPredicates()) {
-
result.getAndPredicates().add(createAndPredicate(eachLeft, eachRight));
- }
- }
+ processAndExpression(result);
Review comment:
Okay,I'll do it and add UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
