taojintianxia commented on a change in pull request #11767:
URL: https://github.com/apache/shardingsphere/pull/11767#discussion_r689316844
##########
File path:
shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/metadata/schema/builder/loader/dialect/H2TableMetaDataLoader.java
##########
@@ -164,14 +178,15 @@ private String getPrimaryKeyMetaDataSQL(final
Collection<String> existedTables)
return result;
}
- private String getGeneratedInfoSQL(final Collection<String> existedTables)
{
- return existedTables.isEmpty() ? GENERATED_INFO_SQL
- : String.format(GENERATED_INFO_SQL_WITH_EXISTED_TABLES,
existedTables.stream().map(each -> String.format("'%s'",
each)).collect(Collectors.joining(",")));
+ private String getGeneratedInfoSQL(final Collection<String> tables, final
boolean isExclude) {
Review comment:
conditional-operator appear two times in one clause ? I believe this is
easy to make people confused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
